fast/files/blob-network-process-crash.html, the test added in https://trac.webkit.org/changeset/235243 is flaky when the timer isn't saved in the global object. This is an indicative of some bug elsewhere. Scheduling another timer seems to fix the problem as well.
Committed r235264: <https://trac.webkit.org/changeset/235264>
<rdar://problem/43666603>
Ugh... I didn't mean to close this bug.
Hm... the test is still flaky on bots.
Added the flaky test expectation in https://trac.webkit.org/changeset/235269. This is very weird. I suspect the bots are too overloaded to sanely process the crashing network process. We should probably replace this test with an API test.
Created attachment 347991 [details] Fix attempt
Comment on attachment 347991 [details] Fix attempt View in context: https://bugs.webkit.org/attachment.cgi?id=347991&action=review > LayoutTests/fast/files/blob-network-process-crash.html:17 > + setTimeout(() => testRunner.notifyDone(), 3000); Let's remove this as you said on IRC > LayoutTests/fast/files/blob-network-process-crash.html:37 > + await fetch('blob-network-process-crash.html'); Do we really need this here? Seems like we would have either crashed or not crashed at this point.
(In reply to Saam Barati from comment #7) > Comment on attachment 347991 [details] > Fix attempt > > View in context: > https://bugs.webkit.org/attachment.cgi?id=347991&action=review > > > LayoutTests/fast/files/blob-network-process-crash.html:17 > > + setTimeout(() => testRunner.notifyDone(), 3000); > > Let's remove this as you said on IRC Will do. > > LayoutTests/fast/files/blob-network-process-crash.html:37 > > + await fetch('blob-network-process-crash.html'); > > Do we really need this here? Seems like we would have either crashed or not > crashed at this point. This call is needed to ensure the network process had received IPC to unregister the blob since that's async.
Committed r235274: <https://trac.webkit.org/changeset/235274>
Keeping this bug open until I confirm that the flakiness is fixed: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Ffiles%2Fblob-network-process-crash.html
The test appears to be no longer flaky. Removed the flaky test expectation in https://trac.webkit.org/changeset/235330.