Bug 188911 - fast/files/blob-network-process-crash.html is flaky
Summary: fast/files/blob-network-process-crash.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-23 17:42 PDT by Ryosuke Niwa
Modified: 2018-08-24 13:13 PDT (History)
4 users (show)

See Also:


Attachments
Fix attempt (2.77 KB, patch)
2018-08-23 22:28 PDT, Ryosuke Niwa
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-08-23 17:42:10 PDT
fast/files/blob-network-process-crash.html, 
the test added in https://trac.webkit.org/changeset/235243 is flaky
when the timer isn't saved in the global object.

This is an indicative of some bug elsewhere.

Scheduling another timer seems to fix the problem as well.
Comment 1 Ryosuke Niwa 2018-08-23 17:43:33 PDT
Committed r235264: <https://trac.webkit.org/changeset/235264>
Comment 2 Radar WebKit Bug Importer 2018-08-23 17:44:18 PDT
<rdar://problem/43666603>
Comment 3 Ryosuke Niwa 2018-08-23 17:45:23 PDT
Ugh... I didn't mean to close this bug.
Comment 4 Ryosuke Niwa 2018-08-23 20:37:02 PDT
Hm... the test is still flaky on bots.
Comment 5 Ryosuke Niwa 2018-08-23 20:42:36 PDT
Added the flaky test expectation in https://trac.webkit.org/changeset/235269.

This is very weird. I suspect the bots are too overloaded to sanely process the crashing network process. We should probably replace this test with an API test.
Comment 6 Ryosuke Niwa 2018-08-23 22:28:58 PDT
Created attachment 347991 [details]
Fix attempt
Comment 7 Saam Barati 2018-08-23 22:48:01 PDT
Comment on attachment 347991 [details]
Fix attempt

View in context: https://bugs.webkit.org/attachment.cgi?id=347991&action=review

> LayoutTests/fast/files/blob-network-process-crash.html:17
> +    setTimeout(() => testRunner.notifyDone(), 3000);

Let's remove this as you said on IRC

> LayoutTests/fast/files/blob-network-process-crash.html:37
> +    await fetch('blob-network-process-crash.html');

Do we really need this here? Seems like we would have either crashed or not crashed at this point.
Comment 8 Ryosuke Niwa 2018-08-23 22:49:19 PDT
(In reply to Saam Barati from comment #7)
> Comment on attachment 347991 [details]
> Fix attempt
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=347991&action=review
> 
> > LayoutTests/fast/files/blob-network-process-crash.html:17
> > +    setTimeout(() => testRunner.notifyDone(), 3000);
> 
> Let's remove this as you said on IRC

Will do.

> > LayoutTests/fast/files/blob-network-process-crash.html:37
> > +    await fetch('blob-network-process-crash.html');
> 
> Do we really need this here? Seems like we would have either crashed or not
> crashed at this point.

This call is needed to ensure the network process had received IPC to unregister the blob since that's async.
Comment 9 Ryosuke Niwa 2018-08-23 22:51:36 PDT
Committed r235274: <https://trac.webkit.org/changeset/235274>
Comment 10 Ryosuke Niwa 2018-08-23 22:51:54 PDT
Keeping this bug open until I confirm that the flakiness is fixed:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Ffiles%2Fblob-network-process-crash.html
Comment 11 Ryosuke Niwa 2018-08-24 13:12:56 PDT
The test appears to be no longer flaky. Removed the flaky test expectation in https://trac.webkit.org/changeset/235330.