Bug 188906 – Don't launch network process in WebCookieManagerProxy::setHTTPCookieAcceptPolicy

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sihui Liu]

In WebCookieManagerProxy::setHTTPCookieAcceptPolicy, we persist the cookieAcceptPolicy of sharedCookieStorage. When we launch the network process later, we pass the sharedCookieStorage to network process, so network process has the correct cookieAcceptPolicy. Therefore, we don't have to launch the network process and send the setting message if the network process is not launched.

[Sihui Liu]

<rdar://problem/42875795>

[Sihui Liu]

<rdar://problem/43539661>

[Sihui Liu]

Created attachment 347966 [details]
Patch

[Geoffrey Garen]

Comment on attachment 347966 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 347966 [details]
Patch

Clearing flags on attachment: 347966

Committed r235321: <https://trac.webkit.org/changeset/235321>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Sihui Liu]

Failed to invoke the callback in early return.

[Sihui Liu]

Created attachment 348044 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 348044 [details]
Patch

Rejecting attachment 348044 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 348044, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=348044&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=188906&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 348044 from bug 188906.
Fetching: https://bugs.webkit.org/attachment.cgi?id=348044
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog
	M	Source/WebKit/UIProcess/WebCookieManagerProxy.cpp

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: f06372109b0ab3aa050594c410308ffe25d059a4 and refs/remotes/origin/master differ, using rebase:
:040000 040000 a30ae21dc76e281b437ed3a04bfed4ace20e83db 162abbfb909fd78b90c6722de4a4368f8d472b8a M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog
	M	Source/WebKit/UIProcess/WebCookieManagerProxy.cpp

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:
Commits are currently disabled while we update infrastructure.
W: f06372109b0ab3aa050594c410308ffe25d059a4 and refs/remotes/origin/master differ, using rebase:
:040000 040000 a30ae21dc76e281b437ed3a04bfed4ace20e83db 162abbfb909fd78b90c6722de4a4368f8d472b8a M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/8977477

[WebKit Commit Bot]

Comment on attachment 348044 [details]
Patch

Clearing flags on attachment: 348044

Committed r235374: <https://trac.webkit.org/changeset/235374>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.