Bug 188901 - [CMake] Have checks are not getting set inside CMake properly
Summary: [CMake] Have checks are not getting set inside CMake properly
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
Keywords: InRadar
Depends on:
Reported: 2018-08-23 14:04 PDT by Don Olmstead
Modified: 2018-08-23 15:54 PDT (History)
6 users (show)

See Also:

Patch (3.01 KB, patch)
2018-08-23 14:10 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-08-23 14:04:53 PDT
Currently it looks like CMake have checks are not being set properly within the build.

After https://trac.webkit.org/changeset/235241/webkit I noticed that the check for HAVE_MALLOC_TRIM within PerformanceTests/CMakeLists.txt was not set to OFF but instead was set to HAVE_MALLOC_TEST_value.

The cmakeconfig.h however was correct.
Comment 1 Don Olmstead 2018-08-23 14:10:35 PDT
Created attachment 347951 [details]
Comment 2 Michael Catanzaro 2018-08-23 14:31:44 PDT
Comment on attachment 347951 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=347951&action=review

> PerformanceTests/CMakeLists.txt:5
> +else ()
> +    message(WARNING "MallocBench is not available on this platform")

Isn't this warning message just going to be annoying?

> Source/cmake/WebKitFeatures.cmake:365
> -    SET_AND_EXPOSE_TO_BUILD(${_variable} ${_variable}_value)
> +    SET_AND_EXPOSE_TO_BUILD(${_variable} ${${_variable}_value})

Comment 3 Don Olmstead 2018-08-23 15:25:39 PDT
Comment on attachment 347951 [details]

WinCairo EWS had an internal failure. AppleWin EWS is hitting a new compilation error.

I think this is fine but will roll out if WinCairo has problems.
Comment 4 WebKit Commit Bot 2018-08-23 15:53:12 PDT
Comment on attachment 347951 [details]

Clearing flags on attachment: 347951

Committed r235253: <https://trac.webkit.org/changeset/235253>
Comment 5 WebKit Commit Bot 2018-08-23 15:53:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-23 15:54:16 PDT