RESOLVED FIXED 188901
[CMake] Have checks are not getting set inside CMake properly 
https://bugs.webkit.org/show_bug.cgi?id=188901
Summary [CMake] Have checks are not getting set inside CMake properly
Don Olmstead
Reported 2018-08-23 14:04:53 PDT
Currently it looks like CMake have checks are not being set properly within the build. After https://trac.webkit.org/changeset/235241/webkit I noticed that the check for HAVE_MALLOC_TRIM within PerformanceTests/CMakeLists.txt was not set to OFF but instead was set to HAVE_MALLOC_TEST_value. The cmakeconfig.h however was correct.
Attachments
Patch (3.01 KB, patch)
2018-08-23 14:10 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-08-23 14:10:35 PDT
Created attachment 347951 [details] Patch
Michael Catanzaro
Comment 2 2018-08-23 14:31:44 PDT
Comment on attachment 347951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347951&action=review > PerformanceTests/CMakeLists.txt:5 > +else () > + message(WARNING "MallocBench is not available on this platform") Isn't this warning message just going to be annoying? > Source/cmake/WebKitFeatures.cmake:365 > - SET_AND_EXPOSE_TO_BUILD(${_variable} ${_variable}_value) > + SET_AND_EXPOSE_TO_BUILD(${_variable} ${${_variable}_value}) Ouch.
Don Olmstead
Comment 3 2018-08-23 15:25:39 PDT
Comment on attachment 347951 [details] Patch WinCairo EWS had an internal failure. AppleWin EWS is hitting a new compilation error. I think this is fine but will roll out if WinCairo has problems.
WebKit Commit Bot
Comment 4 2018-08-23 15:53:12 PDT
Comment on attachment 347951 [details] Patch Clearing flags on attachment: 347951 Committed r235253: <https://trac.webkit.org/changeset/235253>
WebKit Commit Bot
Comment 5 2018-08-23 15:53:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-08-23 15:54:16 PDT
<rdar://problem/43662371>
Note You need to log in before you can comment on or make changes to this bug.