Bug 188900 - Move vmEntryGlobalObject() to VM from CallFrame.
Summary: Move vmEntryGlobalObject() to VM from CallFrame.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-23 13:35 PDT by Mark Lam
Modified: 2018-08-23 15:57 PDT (History)
10 users (show)

See Also:


Attachments
proposed patch. (39.81 KB, patch)
2018-08-23 14:42 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch w/ GTK build fix. (39.81 KB, patch)
2018-08-23 15:01 PDT, Mark Lam
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-08-23 13:35:32 PDT
It doesn't really belong in CallFrame to begin with.
Comment 1 Radar WebKit Bug Importer 2018-08-23 13:36:00 PDT
<rdar://problem/43655753>
Comment 2 Mark Lam 2018-08-23 14:42:06 PDT
Created attachment 347955 [details]
proposed patch.
Comment 3 Mark Lam 2018-08-23 15:01:53 PDT
Created attachment 347958 [details]
proposed patch w/ GTK build fix.
Comment 4 Michael Saboff 2018-08-23 15:51:36 PDT
Comment on attachment 347958 [details]
proposed patch w/ GTK build fix.

r=me
Comment 5 Mark Lam 2018-08-23 15:57:48 PDT
Thanks for the review.  Landed in r235254: <http://trac.webkit.org/r235254>.