Bug 188898 - [iOS] Test editing/undo/replace-text-in-node-preserving-markers-crash.html crashes
Summary: [iOS] Test editing/undo/replace-text-in-node-preserving-markers-crash.html cr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar, LayoutTestFailure, MakingBotsRed
Depends on:
Blocks:
 
Reported: 2018-08-23 12:38 PDT by Daniel Bates
Modified: 2018-08-23 16:21 PDT (History)
6 users (show)

See Also:

Attachments
[WK1] Stacktrace (10.73 KB, text/plain)
2018-08-23 12:39 PDT, Daniel Bates 		no flags Details
Patch (4.05 KB, patch)
2018-08-23 15:07 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-08-23 12:38:26 PDT 
Steps to reproduce:

Tools/Scripts/run-webkit-tests -1 --debug --no-timeout --no-retry-failures --no-sample-on-timeout --child-processes 1 --iterations 10 --batch-size 10000 --ios-simulator editing/undo/replace-text-in-node-preserving-markers-crash.html

Then the test will crash.

Following <https://trac.webkit.org/changeset/235149> (bug #188800) you can also reproduce this crash in WebKit2, omitting the -1 in the above command line, run:

Tools/Scripts/run-webkit-tests --debug --no-timeout --no-retry-failures --no-sample-on-timeout --child-processes 1 --iterations 10 --batch-size 10000 --ios-simulator editing/undo/replace-text-in-node-preserving-markers-crash.html
Comment 1 Daniel Bates 2018-08-23 12:39:35 PDT 
Created attachment 347947 [details]
[WK1] Stacktrace

Stacktrace when running the test in WebKit1.
Comment 2 Daniel Bates 2018-08-23 15:07:17 PDT 
Created attachment 347959 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-08-23 15:41:05 PDT 
Comment on attachment 347959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347959&action=review

> Source/WebCore/dom/DocumentMarker.h:129
>  #if PLATFORM(IOS)

I wonder if we really need these #ifdefs. Can we just stub things out on macOS?
Comment 4 Daniel Bates 2018-08-23 15:59:32 PDT 
Comment on attachment 347959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347959&action=review

>> Source/WebCore/dom/DocumentMarker.h:129
>>  #if PLATFORM(IOS)
> 
> I wonder if we really need these #ifdefs. Can we just stub things out on macOS?

Yes, but I resisted the temptation to do that now.
Comment 5 Daniel Bates 2018-08-23 16:20:04 PDT 
Comment on attachment 347959 [details]
Patch

Clearing flags on attachment: 347959

Committed r235256: <https://trac.webkit.org/changeset/235256>
Comment 6 Daniel Bates 2018-08-23 16:20:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-23 16:21:17 PDT 
<rdar://problem/43663322>