Bug 188895 – YARR: Need to JIT compile a RegExp before using containsNestedSubpatterns flag

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

There is a slight bug in the RegExp JIT code where we use the m_containsNestedSubpatterns before the JIT compilation has set it.  The result is that this limits somewhat the regexps that can take advantage of JIT'ed greedy sub patterns.

[Michael Saboff]

Created attachment 347944 [details]
Patch

[Mark Lam]

Comment on attachment 347944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347944&action=review

r=me

> Source/JavaScriptCore/yarr/YarrJIT.cpp:3565
> +            codeBlock.setUsesPaternContextBuffer();

nit: "Patern" looks mis-spelled.  Maybe fix in a follow up patch since it's not related to this issue.

[Michael Saboff]

Comment on attachment 347944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347944&action=review

>> Source/JavaScriptCore/yarr/YarrJIT.cpp:3565
>> +            codeBlock.setUsesPaternContextBuffer();
> 
> nit: "Patern" looks mis-spelled.  Maybe fix in a follow up patch since it's not related to this issue.

I fixed that in the patch I'm working on.  I can factor that out if you like.

[Mark Lam]

(In reply to Michael Saboff from comment #3)
> Comment on attachment 347944 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=347944&action=review
> 
> >> Source/JavaScriptCore/yarr/YarrJIT.cpp:3565
> >> +            codeBlock.setUsesPaternContextBuffer();
> > 
> > nit: "Patern" looks mis-spelled.  Maybe fix in a follow up patch since it's not related to this issue.
> 
> I fixed that in the patch I'm working on.  I can factor that out if you like.

Either works for me.

[WebKit Commit Bot]

Comment on attachment 347944 [details]
Patch

Clearing flags on attachment: 347944

Committed r235238: <https://trac.webkit.org/changeset/235238>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43654564>