RESOLVED FIXED 18886
RenderLayer::shouldBeOverflowOnly() should look for transforms
https://bugs.webkit.org/show_bug.cgi?id=18886
Summary RenderLayer::shouldBeOverflowOnly() should look for transforms
Simon Fraser (smfr)
Reported 2008-05-04 11:54:48 PDT
RenderLayer::shouldBeOverflowOnly() decides if a layer is an overflow-only layer (just used for clipping, and not a parent of other RenderLayers). It currently does not look for transforms, which create stacking context and behave like position:relative. I think it should.
Attachments
Testcase (555 bytes, text/html)
2008-07-09 17:56 PDT, Simon Fraser (smfr)
no flags
Patch (508 bytes, patch)
2008-07-09 17:57 PDT, Simon Fraser (smfr)
hyatt: review+
Final patch with changelog and testcase (3.42 KB, patch)
2008-07-10 10:58 PDT, Simon Fraser (smfr)
simon.fraser: review+
Dave Hyatt
Comment 1 2008-07-09 17:45:01 PDT
<body style="margin:0"> <div style="position:absolute; background-color:red; z-index:0; left: 50px; top:50px; width:100px;height:100px"></div> <div style="overflow:auto; -webkit-transform: scale(0.5); background-color:green; z-index:0; width:200px; height:200px"></div>
Dave Hyatt
Comment 2 2008-07-09 17:47:40 PDT
I think that might be a valid test case, but not 100% sure. Would have to think about it some more.
Simon Fraser (smfr)
Comment 3 2008-07-09 17:56:37 PDT
Created attachment 22194 [details] Testcase
Simon Fraser (smfr)
Comment 4 2008-07-09 17:57:41 PDT
Dave Hyatt
Comment 5 2008-07-09 18:02:40 PDT
Comment on attachment 22195 [details] Patch r=me, but need a ChangeLog and the test case included in LayoutTests to land.
Simon Fraser (smfr)
Comment 6 2008-07-10 10:58:47 PDT
Created attachment 22200 [details] Final patch with changelog and testcase
Simon Fraser (smfr)
Comment 7 2008-07-10 11:07:58 PDT
Comment on attachment 22200 [details] Final patch with changelog and testcase Transferring r= from hyatt
Dean Jackson
Comment 8 2008-07-10 12:15:47 PDT
Committed r35100
Simon Fraser (smfr)
Comment 9 2008-07-10 13:48:26 PDT
Committed by dino in r35100
Note You need to log in before you can comment on or make changes to this bug.