Bug 188858 - Don't use WTF_CPU_MIPS when building for mips64
Summary: Don't use WTF_CPU_MIPS when building for mips64
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2018-08-22 12:52 PDT by Alberto Garcia
Modified: 2018-08-22 13:29 PDT (History)
6 users (show)

See Also:

Patch (1.05 KB, patch)
2018-08-22 12:54 PDT, Alberto Garcia
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2018-08-22 12:52:09 PDT
We want that the build system detects automatically when to enable the JIT, but we can't do it with mips64 as we do it for mips, since the former is not supported and results on a build failure:

In file included from Source/JavaScriptCore/jit/GPRInfo.h:28,
                 from Source/JavaScriptCore/interpreter/VMEntryRecord.h:28,
                 from Source/JavaScriptCore/interpreter/StackVisitor.h:29,
                 from Source/JavaScriptCore/interpreter/CallFrame.h:29,
                 from Source/JavaScriptCore/runtime/ClassInfo.h:25,
                 from Source/JavaScriptCore/runtime/Structure.h:28,
                 from Source/JavaScriptCore/bytecode/ArrayProfile.h:29,
                 from Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:28:
Source/JavaScriptCore/assembler/MacroAssembler.h:69:2: error: #error "The MacroAssembler is not supported on this platform."

There's a separate WTF_CPU_MIPS64 for this architecture.
Comment 1 Alberto Garcia 2018-08-22 12:54:21 PDT
Created attachment 347832 [details]
Comment 2 Michael Catanzaro 2018-08-22 13:22:31 PDT
Comment on attachment 347832 [details]

* Reviewed all the checks in existing CMake code
 * Verified this matches WTF's WTF_CPU_MIPS64 macro
 * Good!
Comment 3 Alberto Garcia 2018-08-22 13:27:32 PDT
Committed r235194: <https://trac.webkit.org/changeset/235194>
Comment 4 Radar WebKit Bug Importer 2018-08-22 13:29:05 PDT