Bug 188856 - Restructure and rename http/tests/websocket/construct-in-detached-frame-resource-load-statistics.html to address flakiness
Summary: Restructure and rename http/tests/websocket/construct-in-detached-frame-resou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-22 10:41 PDT by John Wilander
Modified: 2018-08-23 07:56 PDT (History)
3 users (show)

See Also:

Attachments
Patch for landing (8.34 KB, patch)
2018-08-22 10:45 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-01 for mac-sierra (2.30 MB, application/zip)
2018-08-22 11:51 PDT, WebKit Commit Bot 		no flags Details
Patch for landing (10.31 KB, patch)
2018-08-22 12:28 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
Patch for landing (3.20 KB, patch)
2018-08-22 15:30 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2018-08-22 10:41:54 PDT 
http/tests/websocket/construct-in-detached-frame-resource-load-statistics.html is flaky as reported in https://bugs.webkit.org/show_bug.cgi?id=188757.
Comment 1 John Wilander 2018-08-22 10:45:53 PDT 
Created attachment 347819 [details]
Patch for landing
Comment 2 WebKit Commit Bot 2018-08-22 11:51:09 PDT 
Comment on attachment 347819 [details]
Patch for landing

Rejecting attachment 347819 [details] from commit-queue.

New failing tests:
http/tests/websocket/connection-refusal-in-frame-resource-load-statistics.html
Full output: https://webkit-queues.webkit.org/results/8947087
Comment 3 WebKit Commit Bot 2018-08-22 11:51:10 PDT 
Created attachment 347822 [details]
Archive of layout-test-results from webkit-cq-01 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 4 John Wilander 2018-08-22 11:59:41 PDT 
Forgot to change the test expectations. :/ Will fix.
Comment 5 John Wilander 2018-08-22 12:28:43 PDT 
Created attachment 347828 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-08-22 13:07:26 PDT 
Comment on attachment 347828 [details]
Patch for landing

Clearing flags on attachment: 347828

Committed r235193: <https://trac.webkit.org/changeset/235193>
Comment 7 WebKit Commit Bot 2018-08-22 13:07:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-08-22 13:08:19 PDT 
<rdar://problem/43617155>
Comment 9 John Wilander 2018-08-22 15:30:09 PDT 
Reopening to attach new patch.
Comment 10 John Wilander 2018-08-22 15:30:10 PDT 
Created attachment 347854 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2018-08-22 16:10:44 PDT 
Comment on attachment 347854 [details]
Patch for landing

Clearing flags on attachment: 347854

Committed r235210: <https://trac.webkit.org/changeset/235210>
Comment 12 WebKit Commit Bot 2018-08-22 16:10:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 13 John Wilander 2018-08-23 07:56:30 PDT 
Flakiness dashboard now indicates that this test is no longer failing. It is slow, but that is expected. I may revisit to see if I can speed it up but it's waiting for a timer to fire.