Before running the tool I wrote for Bug 188754 (Tool to fix folders that should map to directories in Xcode project files), we need to move 6 files in the WebCore project so that they appear where the Xcode project shows them in its folders.
This patch mostly consists of 6 file moves (and fixing 3 style warnings for WAKViewInternal.h): [master 4e8c3d6446f] Move files in WebCore project to match Xcode folder structure <https://webkit.org/b/188851> 11 files changed, 40 insertions(+), 11 deletions(-) rename Source/WebCore/{ => Scripts}/LocalizableStrings.pm (100%) rename Source/WebCore/{ => Scripts}/extract-localizable-strings.pl (100%) rename Source/WebCore/platform/audio/{ => cocoa}/WebAudioBufferList.cpp (100%) rename Source/WebCore/platform/audio/{ => cocoa}/WebAudioBufferList.h (100%) rename Source/WebCore/platform/graphics/avfoundation/{ => objc}/MediaSampleAVFObjC.h (100%) rename Source/WebCore/platform/{ => ios/wak}/WAKViewInternal.h (90%)
Created attachment 347810 [details] Patch v1
(In reply to David Kilzer (:ddkilzer) from comment #1) > This patch mostly consists of 6 file moves (and fixing 3 style warnings for > WAKViewInternal.h): > > [master 4e8c3d6446f] Move files in WebCore project to match Xcode folder > structure <https://webkit.org/b/188851> > 11 files changed, 40 insertions(+), 11 deletions(-) > rename Source/WebCore/{ => Scripts}/LocalizableStrings.pm (100%) > rename Source/WebCore/{ => Scripts}/extract-localizable-strings.pl (100%) > rename Source/WebCore/platform/audio/{ => cocoa}/WebAudioBufferList.cpp > (100%) > rename Source/WebCore/platform/audio/{ => cocoa}/WebAudioBufferList.h (100%) > rename Source/WebCore/platform/graphics/avfoundation/{ => > objc}/MediaSampleAVFObjC.h (100%) > rename Source/WebCore/platform/{ => ios/wak}/WAKViewInternal.h (90%) This is the WAKViewInternal.h change: diff --git a/Source/WebCore/platform/WAKViewInternal.h b/Source/WebCore/platform/ios/wak/WAKViewInternal.h similarity index 90% rename from Source/WebCore/platform/WAKViewInternal.h rename to Source/WebCore/platform/ios/wak/WAKViewInternal.h index 94f98dd299c..cad06283719 100644 --- a/Source/WebCore/platform/WAKViewInternal.h +++ b/Source/WebCore/platform/ios/wak/WAKViewInternal.h @@ -28,13 +28,15 @@ #import "WAKView.h" #import "WKView.h" -@interface WAKView () { +@interface WAKView () +{ @package WKViewContext viewContext; WKViewRef viewRef; - NSMutableSet *subviewReferences; // This array is only used to keep WAKViews alive. - // The actual subviews are maintained by the WKView. + // This array is only used to keep WAKViews alive. + // The actual subviews are maintained by the WKView. + NSMutableSet *subviewReferences; BOOL _isHidden; BOOL _drawsOwnDescendants;
Comment on attachment 347810 [details] Patch v1 Clearing flags on attachment: 347810 Committed r235190: <https://trac.webkit.org/changeset/235190>
All reviewed patches have been landed. Closing bug.
<rdar://problem/43616125>