Bug 188846 - [LFC][Floating] Move files to a dedicated directory.
Summary: [LFC][Floating] Move files to a dedicated directory.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-22 07:42 PDT by zalan
Modified: 2018-08-22 10:13 PDT (History)
6 users (show)

See Also:


Attachments
Patch (74.56 KB, patch)
2018-08-22 07:46 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (75.53 KB, patch)
2018-08-22 07:54 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (74.08 KB, patch)
2018-08-22 09:07 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (74.07 KB, patch)
2018-08-22 09:30 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-08-22 07:42:51 PDT
->floatformatting
Comment 1 zalan 2018-08-22 07:46:19 PDT
Created attachment 347790 [details]
Patch
Comment 2 zalan 2018-08-22 07:54:49 PDT
Created attachment 347791 [details]
Patch
Comment 3 Simon Fraser (smfr) 2018-08-22 08:27:01 PDT
Comment on attachment 347791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347791&action=review

> Source/WebCore/ChangeLog:8
> +        layout/Float* -> layout/floatformatting

floatformatting is a bit of a mouthful. Maybe layout/floats?

I see you have blockformatting now, so maybe that should be layout/block too.
Comment 4 zalan 2018-08-22 09:07:48 PDT
Created attachment 347801 [details]
Patch
Comment 5 zalan 2018-08-22 09:30:26 PDT
Created attachment 347806 [details]
Patch
Comment 6 WebKit Commit Bot 2018-08-22 10:10:41 PDT
Comment on attachment 347806 [details]
Patch

Clearing flags on attachment: 347806

Committed r235178: <https://trac.webkit.org/changeset/235178>
Comment 7 WebKit Commit Bot 2018-08-22 10:10:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-08-22 10:13:07 PDT
<rdar://problem/43609708>