[CoordGraphics] Remove the 'previous backing store' logic

[Zan Dobersek]

In CoordinatedGraphicsLayer, the current backing store is sometimes kept around after it's removed, in order to keep the tile data contained there alive for the near future. I think this is a remnant from the cross-process CoordinatedGraphics usage that's not obsolete. The previous backing store management should thus probably be possible to remove.

This report originates from bug #188693.

[Miguel Gomez]

I always wondered what was the previous backingStore about and whether we could remove it, but never had time to check it. I'll add this to my list.

[Carlos Bentzen]

Created attachment 351516 [details]
Patch

[Miguel Gomez]

Comment on attachment 351516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351516&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:872
>          m_pendingContentsScaleAdjustment = false;

You changed the logic here. m_pendingContentsScaleAdjustment must always be set to false if it was true, not only when the three conditions are met.

[Carlos Bentzen]

(In reply to Miguel Gomez from comment #3)
> Comment on attachment 351516 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=351516&action=review
> 
> > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:872
> >          m_pendingContentsScaleAdjustment = false;
> 
> You changed the logic here. m_pendingContentsScaleAdjustment must always be
> set to false if it was true, not only when the three conditions are met.

True.

Thanks for the review!

[Carlos Bentzen]

Created attachment 351594 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 351594 [details]
Patch

Clearing flags on attachment: 351594

Committed r236974: <https://trac.webkit.org/changeset/236974>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45135211>