Bug 188830 - The Storage Access API prompt should show the eTLD+1s, not the full host names
Summary: The Storage Access API prompt should show the eTLD+1s, not the full host names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-21 17:08 PDT by John Wilander
Modified: 2018-08-22 15:54 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.49 KB, patch)
2018-08-21 17:12 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2018-08-21 17:08:53 PDT 
WebKit::WebPageProxy::requestStorageAccess()'s handling of the StorageAccessStatus::RequiresUserPrompt case should pass on the eTLD+1 for the top and sub frames, not their full host names.
Comment 1 John Wilander 2018-08-21 17:09:04 PDT 
<rdar://problem/43380645>
Comment 2 John Wilander 2018-08-21 17:12:37 PDT 
Created attachment 347738 [details]
Patch
Comment 3 Brent Fulgham 2018-08-22 15:38:08 PDT 
Comment on attachment 347738 [details]
Patch

r=me.
Comment 4 John Wilander 2018-08-22 15:38:45 PDT 
Comment on attachment 347738 [details]
Patch

Thanks, Brent!
Comment 5 WebKit Commit Bot 2018-08-22 15:54:41 PDT 
Comment on attachment 347738 [details]
Patch

Clearing flags on attachment: 347738

Committed r235209: <https://trac.webkit.org/changeset/235209>
Comment 6 WebKit Commit Bot 2018-08-22 15:54:43 PDT 
All reviewed patches have been landed.  Closing bug.