Bug 188829 – [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave

[Andy Estes]

Created attachment 347728 [details]
Patch

[EWS Watchlist]

Attachment 347728 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: LayoutTests/platform/mac-wk2/TestExpectations:756:  Path does not exist.  [test/expectations] [5]
ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebCore/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0:  Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/Configurations/FeatureDefines.xcconfig). Use sync-feature-defines if possible.  [featuredefines/equality] [5]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/mac-wk2/TestExpectations:756:  Path does not exist.  [test/expectations] [5]
Total errors found: 8 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 347728 [details]
Patch

Attachment 347728 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8942070

New failing tests:
http/tests/security/local-video-source-from-remote.html

[EWS Watchlist]

Created attachment 347775 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Andy Estes]

Created attachment 347848 [details]
Patch

[EWS Watchlist]

Comment on attachment 347848 [details]
Patch

Attachment 347848 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8949819

New failing tests:
http/tests/ssl/applepay/ApplePaySessionV4.html

[EWS Watchlist]

Created attachment 347868 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Andy Estes]

Created attachment 347873 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 347873 [details]
Patch

Clearing flags on attachment: 347873

Committed r235251: <https://trac.webkit.org/changeset/235251>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43661017>