Bug 188826 – Change Selection modification to not snap the grabber when selecting above or below the selection anchor

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Change Selection modification to not snap the grabber when selecting above or below the selection anchor

[Megan Gardner]

Created attachment 347724 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/43583165>

[Tim Horton]

Comment on attachment 347724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347724&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1224
> +    IntPoint adjustedPoint(pointInRootViewCoordinates.x(), pointInRootViewCoordinates.y());

Why not just `IntPoint adjustedPoint = pointInRootViewCoordinates`?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1228
> +        int startY = caret.y() + caret.height() / 2;

We have center(), maybe use that?

[Wenson Hsieh]

Comment on attachment 347724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347724&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1242
> +    HitTestResult hitTest = frame.eventHandler().hitTestResultAtPoint(adjustedPoint, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowChildFrameContent);

adjustedPoint is in root view coordinates, no?

[Tim Horton]

Comment on attachment 347724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347724&action=review

>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1242
>> +    HitTestResult hitTest = frame.eventHandler().hitTestResultAtPoint(adjustedPoint, HitTestRequest::ReadOnly | HitTestRequest::Active | HitTestRequest::AllowChildFrameContent);
> 
> adjustedPoint is in root view coordinates, no?

Oops.

[Megan Gardner]

Created attachment 347741 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 347741 [details]
Patch for landing

Clearing flags on attachment: 347741

Committed r235153: <https://trac.webkit.org/changeset/235153>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Ryan is fixing layout tests in bug 188888. In the future, please wait for EWS before landing patches.

[Wenson Hsieh]

Comment on attachment 347741 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=347741&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1230
> +            adjustedPoint.setY(startY);

It looks like the caret bounds are in content coordinates, but adjusted point is in root view coordinates?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1235
> +            adjustedPoint.setY(endY);

(Here too)