RESOLVED FIXED 18882
nspluginwrapper causes segfault in WebKit 
https://bugs.webkit.org/show_bug.cgi?id=18882
Summary nspluginwrapper causes segfault in WebKit
Chris Lord
Reported 2008-05-04 03:55:10 PDT
nspluginwrapper causes webkit to segfault when it calls NPN_GetURLNotify with a NULL instance. Attached backtrace and patch that fixes it. It seems that plugins expect to be able to call NPN functions with a NULL instance after the browser has called into an NPP function - Should all m_plugin->pluginFuncs()->*() be wrapped in a setCurrentPluginView(this/0) block?
Attachments
Backtrace (2.97 KB, text/plain)
2008-05-04 03:55 PDT, Chris Lord 		no flags
Details
Patch that fixes the problem (1.76 KB, patch)
2008-05-04 03:56 PDT, Chris Lord 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Lord
Comment 1 2008-05-04 03:55:47 PDT
Created attachment 20957 [details] Backtrace
Chris Lord
Comment 2 2008-05-04 03:56:53 PDT
Created attachment 20958 [details] Patch that fixes the problem
marcoil
Comment 3 2008-05-07 02:31:54 PDT
(In reply to comment #2) > Created an attachment (id=20958) [edit] > Patch that fixes the problem > I've made a patch for bug #18892 (attachment #20998 [details]) that includes your fix, could you test it with nspluginwrapper? Thanks!
marcos pinto
Comment 4 2008-05-07 15:47:40 PDT
works perfectly here, thanks. hope it gets committed soon
marcoil
Comment 5 2008-05-19 03:15:46 PDT
Patch landed in r33570.
marcoil
Comment 6 2008-05-20 04:36:47 PDT
Chris Lord's patch that fixes this was included in my patch for bug #18892 and landed in r33750, so I'm closing this one. Thanks, Chris!
Note You need to log in before you can comment on or make changes to this bug.