Bug 188818 - Cleanup: Remove unused file-local static variable from TextCheckerIOS.mm
Summary: Cleanup: Remove unused file-local static variable from TextCheckerIOS.mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-21 14:53 PDT by Daniel Bates
Modified: 2018-08-22 09:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2018-08-21 14:54 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-08-21 14:53:03 PDT 
Remove the file-local static variable, smartInsertDeleteEnabled, as it is unused and increases binary size.

$ nm -a WebKitBuild/Debug-iphonesimulator/WebKit.framework/WebKit | grep smartInsertDeleteEnabled
...
00000000017f0970 b __ZN6WebKitL24smartInsertDeleteEnabledE
Comment 1 Daniel Bates 2018-08-21 14:54:17 PDT 
Created attachment 347704 [details]
Patch
Comment 2 Daniel Bates 2018-08-21 17:49:40 PDT 
Comment on attachment 347704 [details]
Patch

Clearing flags on attachment: 347704

Committed r235150: <https://trac.webkit.org/changeset/235150>
Comment 3 Daniel Bates 2018-08-21 17:49:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-08-21 17:50:17 PDT 
<rdar://problem/43585928>
Comment 5 Daniel Bates 2018-08-22 09:44:19 PDT 
(In reply to Daniel Bates from comment #0)
> Remove the file-local static variable, smartInsertDeleteEnabled, as it is
> unused and increases binary size.

Disregard the remark about increasing binary size.