RESOLVED FIXED 188818
Cleanup: Remove unused file-local static variable from TextCheckerIOS.mm 
https://bugs.webkit.org/show_bug.cgi?id=188818
Summary Cleanup: Remove unused file-local static variable from TextCheckerIOS.mm
Daniel Bates
Reported 2018-08-21 14:53:03 PDT
Remove the file-local static variable, smartInsertDeleteEnabled, as it is unused and increases binary size. $ nm -a WebKitBuild/Debug-iphonesimulator/WebKit.framework/WebKit | grep smartInsertDeleteEnabled ... 00000000017f0970 b __ZN6WebKitL24smartInsertDeleteEnabledE
Attachments
Patch (1.30 KB, patch)
2018-08-21 14:54 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-08-21 14:54:17 PDT
Created attachment 347704 [details] Patch
Daniel Bates
Comment 2 2018-08-21 17:49:40 PDT
Comment on attachment 347704 [details] Patch Clearing flags on attachment: 347704 Committed r235150: <https://trac.webkit.org/changeset/235150>
Daniel Bates
Comment 3 2018-08-21 17:49:43 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-08-21 17:50:17 PDT
<rdar://problem/43585928>
Daniel Bates
Comment 5 2018-08-22 09:44:19 PDT
(In reply to Daniel Bates from comment #0) > Remove the file-local static variable, smartInsertDeleteEnabled, as it is > unused and increases binary size. Disregard the remark about increasing binary size.
Note You need to log in before you can comment on or make changes to this bug.