Bug 188815 - Web Inspector: ⌘G does not while find banner is focused
Summary: Web Inspector: ⌘G does not while find banner is focused
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-21 14:20 PDT by Joseph Pecoraro
Modified: 2018-08-21 16:58 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (2.16 KB, patch)
2018-08-21 14:26 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-02 for mac-sierra (2.31 MB, application/zip)
2018-08-21 15:59 PDT, WebKit Commit Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-08-21 14:20:38 PDT
⌘G does not while find banner is focused

Steps to Reproduce:
1. Inspector <http://webkit.org>
2. Show global.js
3. Show find banner (⌘F)
4. Search for "document"
5. While find banner is focused use ⌘G
  => Expected it to work, instead nothing happened
Comment 1 Joseph Pecoraro 2018-08-21 14:22:19 PDT
I suspect this is related to:
https://bugs.webkit.org/show_bug.cgi?id=169804

I made sure that didn't regress.
Comment 2 Radar WebKit Bug Importer 2018-08-21 14:23:45 PDT
<rdar://problem/43577158>
Comment 3 Joseph Pecoraro 2018-08-21 14:26:50 PDT
Created attachment 347695 [details]
[PATCH] Proposed Fix
Comment 4 Matt Baker 2018-08-21 15:18:34 PDT
Comment on attachment 347695 [details]
[PATCH] Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2018-08-21 15:59:13 PDT
Comment on attachment 347695 [details]
[PATCH] Proposed Fix

Rejecting attachment 347695 [details] from commit-queue.

New failing tests:
http/wpt/workers/name-property-enhanced.html
Full output: https://webkit-queues.webkit.org/results/8935731
Comment 6 WebKit Commit Bot 2018-08-21 15:59:14 PDT
Created attachment 347719 [details]
Archive of layout-test-results from webkit-cq-02 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 WebKit Commit Bot 2018-08-21 16:58:27 PDT
Comment on attachment 347695 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 347695

Committed r235147: <https://trac.webkit.org/changeset/235147>
Comment 8 WebKit Commit Bot 2018-08-21 16:58:29 PDT
All reviewed patches have been landed.  Closing bug.