Bug 188803 - Web Inspector: cannot delete multiple event breakpoints by repeatedly hitting delete
Summary: Web Inspector: cannot delete multiple event breakpoints by repeatedly hitting...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-21 12:31 PDT by Matt Baker
Modified: 2018-08-22 10:56 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.92 KB, patch)
2018-08-21 23:50 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-08-21 12:31:50 PDT 
The next breakpoint in the tree is selected, but doesn't have the focus, preventing the next delete key press to do nothing.

Steps to Reproduce:
1. Debugger tab
2. Add multiple Event Breakpoints
3. Select the last breakpoint item in the list
4. Press the delete key
  => Breakpoint deleted, previous breakpoint item is selected
5. Hit delete key
  => Nothing happens, because the tree outline has lost the focus
Comment 1 Radar WebKit Bug Importer 2018-08-21 12:34:03 PDT 
<rdar://problem/43572838>
Comment 2 Devin Rousso 2018-08-21 23:50:21 PDT 
Created attachment 347771 [details]
Patch
Comment 3 Matt Baker 2018-08-22 10:29:08 PDT 
Comment on attachment 347771 [details]
Patch

We removed and re-appended the tree whenever a breakpoint was deleted! Looks like copypasta from the broken code I added for DOM breakpoints. :(
Comment 4 WebKit Commit Bot 2018-08-22 10:56:50 PDT 
Comment on attachment 347771 [details]
Patch

Clearing flags on attachment: 347771

Committed r235183: <https://trac.webkit.org/changeset/235183>
Comment 5 WebKit Commit Bot 2018-08-22 10:56:52 PDT 
All reviewed patches have been landed.  Closing bug.