RESOLVED WONTFIX 188788
LEBDecoder and Wasm::Parser should be tolerant for not enough data 
https://bugs.webkit.org/show_bug.cgi?id=188788
Summary LEBDecoder and Wasm::Parser should be tolerant for not enough data
Yusuke Suzuki
Reported 2018-08-21 05:32:36 PDT
LEBDecoder and Wasm::Parser should be tolerant for not enough data
Attachments
Patch (49.93 KB, patch)
2018-08-21 05:35 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-08-21 05:35:42 PDT
Created attachment 347632 [details] Patch
EWS Watchlist
Comment 2 2018-08-21 05:37:18 PDT
Attachment 347632 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WasmParser.h:237: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 3 2018-08-21 19:50:15 PDT
Comment on attachment 347632 [details] Patch Seems like we’re doing this at such a low level. Why can’t we wait until we have enough bytes for the module header then just know when we can individually parse functions at their byte boundaries?
Yusuke Suzuki
Comment 4 2018-08-25 04:25:27 PDT
(In reply to Saam Barati from comment #3) > Comment on attachment 347632 [details] > Patch > > Seems like we’re doing this at such a low level. Why can’t we wait until we > have enough bytes for the module header then just know when we can > individually parse functions at their byte boundaries? Make sense. After reading Wasm module specification carefully, we do not need to have such a low level tolerance in LEBDecoder etc. Closing this issue. Without it, we can construct streaming decoder for wasm.
Note You need to log in before you can comment on or make changes to this bug.