Replace booleans for control, alt, meta, etc... keys with OptionSet of modifiers.
Created attachment 347610 [details] WIP
Attachment 347610 [details] did not pass style-queue: ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/SimulatedClick.cpp:47: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:43: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 9 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 347694 [details] Cleanup
Attachment 347694 [details] did not pass style-queue: ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/SimulatedClick.cpp:47: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:43: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 8 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
<rdar://problem/43577361>
Created attachment 347711 [details] WPE build fix
Comment on attachment 347694 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=347694&action=review > Source/WebCore/ChangeLog:8 > + Replaced boolean arguments and instance variables for modififer keys (ctrl, alt, shift, and meta keys) in modififer > Source/WebCore/platform/PlatformEvent.h:73 > + enum class Modifier : uint8_t { I think this should be called Modifiers (or maybe ModifierKeys?)
(In reply to Simon Fraser (smfr) from comment #7) > Comment on attachment 347694 [details] > Cleanup > > View in context: > https://bugs.webkit.org/attachment.cgi?id=347694&action=review > > > Source/WebCore/ChangeLog:8 > > + Replaced boolean arguments and instance variables for modififer keys (ctrl, alt, shift, and meta keys) in > > modififer Fixed. > > Source/WebCore/platform/PlatformEvent.h:73 > > + enum class Modifier : uint8_t { > > I think this should be called Modifiers (or maybe ModifierKeys?) I think we ordinarily use singular noun for enum class itself.
Attachment 347711 [details] did not pass style-queue: ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/SimulatedClick.cpp:47: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:43: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 8 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 347751 [details] Patch for landing
Comment on attachment 347751 [details] Patch for landing Wait for EWS
Attachment 347751 [details] did not pass style-queue: ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/TouchEvent.cpp:41: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseEvent.cpp:83: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/SimulatedClick.cpp:47: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:38: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:43: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 8 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 347751 [details] Patch for landing Clearing flags on attachment: 347751 Committed r235158: <https://trac.webkit.org/changeset/235158>
All reviewed patches have been landed. Closing bug.
Mass move bugs into the DOM component.