Bug 188771 - Replace WKPageLoaderClient with WKPageNavigationClient in many API tests
Summary: Replace WKPageLoaderClient with WKPageNavigationClient in many API tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-20 17:49 PDT by Alex Christensen
Modified: 2018-08-21 09:18 PDT (History)
3 users (show)

See Also:


Attachments
Patch (71.44 KB, patch)
2018-08-20 17:51 PDT, Alex Christensen
thorton: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews201 for win-future (12.84 MB, application/zip)
2018-08-21 08:51 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-20 17:49:37 PDT
Replace WKPageLoaderClient with WKPageNavigationClient in many API tests
Comment 1 Alex Christensen 2018-08-20 17:51:00 PDT
Created attachment 347588 [details]
Patch
Comment 2 Tim Horton 2018-08-20 18:01:14 PDT
Comment on attachment 347588 [details]
Patch

rs=me if the tests pass
Comment 3 EWS Watchlist 2018-08-21 08:51:15 PDT
Comment on attachment 347588 [details]
Patch

Attachment 347588 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8930464

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Comment 4 EWS Watchlist 2018-08-21 08:51:26 PDT
Created attachment 347644 [details]
Archive of layout-test-results from ews201 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Alex Christensen 2018-08-21 09:17:21 PDT
Tests pass and I changed the auto... to parameter names to make GTK happy.
http://trac.webkit.org/r235117
Comment 6 Radar WebKit Bug Importer 2018-08-21 09:18:31 PDT
<rdar://problem/43563883>