Bug 188767 – Use VisiblePosition to calculate selection ranges

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Use VisiblePosition to calculate selection ranges

[Megan Gardner]

Created attachment 347572 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 347572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347572&action=review

> Source/WebKit/ChangeLog:11
> +        when trying to snap a selection. VisiblePosition gives us the correct information, and does not 
> +        result is collapsed ranges.

does not result *in*?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1233
>      

This function seems to have a lot of whitespace on blank lines :(
Could you please fix them while we're at it?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1235
> +        if (comparePositions(result.deepEquivalent(), selectionStart.deepEquivalent()) <= 0)

This isn't right. comparePositions in Editing.h takes VisiblePositions.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1239
> +        

Nit: Whitespace.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1243
> -        if (comparePositions(selectionEnd, result) <= 0)
> +        if (comparePositions(selectionEnd.deepEquivalent(), result.deepEquivalent()) <= 0)

This isn't right. comparePositions in Editing.h takes VisiblePositions.

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1247
> +        

Nit: Whitespace.

[EWS Watchlist]

Comment on attachment 347572 [details]
Patch

Attachment 347572 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8929866

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

[EWS Watchlist]

Created attachment 347639 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Radar WebKit Bug Importer]

<rdar://problem/43577166>

[Megan Gardner]

Created attachment 347696 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 347696 [details]
Patch for landing

Clearing flags on attachment: 347696

Committed r235143: <https://trac.webkit.org/changeset/235143>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.