Bug 188765 - Move legacy directory configuration from WebProcessPool to API::WebsiteDataStore
Summary: Move legacy directory configuration from WebProcessPool to API::WebsiteDataStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on: 188887
Blocks:
  Show dependency tree / graph
 
Reported: 2018-08-20 16:41 PDT by Sihui Liu
Modified: 2018-08-23 16:37 PDT (History)
11 users (show)

See Also:

Attachments
Patch (21.97 KB, patch)
2018-08-20 16:50 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (39.15 KB, patch)
2018-08-21 10:37 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (39.17 KB, patch)
2018-08-21 11:36 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (39.18 KB, patch)
2018-08-21 13:29 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (39.19 KB, patch)
2018-08-21 14:09 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-sierra (3.04 MB, application/zip)
2018-08-21 16:24 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews206 for win-future (12.89 MB, application/zip)
2018-08-21 20:33 PDT, EWS Watchlist 		no flags Details
Patch (39.41 KB, patch)
2018-08-22 10:07 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (39.79 KB, patch)
2018-08-23 11:45 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2018-08-20 16:41:06 PDT 
Start to move directory setting from processPool to websiteDataStore.
Comment 1 Sihui Liu 2018-08-20 16:50:49 PDT 
Created attachment 347570 [details]
Patch
Comment 2 Sihui Liu 2018-08-21 10:37:42 PDT 
Created attachment 347656 [details]
Patch
Comment 3 EWS Watchlist 2018-08-21 10:39:39 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Sihui Liu 2018-08-21 11:36:20 PDT 
Created attachment 347663 [details]
Patch
Comment 5 Sihui Liu 2018-08-21 13:29:44 PDT 
Created attachment 347680 [details]
Patch
Comment 6 Sihui Liu 2018-08-21 14:09:50 PDT 
Created attachment 347691 [details]
Patch
Comment 7 Ryosuke Niwa 2018-08-21 16:22:41 PDT 
Comment on attachment 347691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347691&action=review

> Source/WebKit/ChangeLog:7
> +

Please explain why we want to do this in the change log.
Comment 8 EWS Watchlist 2018-08-21 16:24:57 PDT 
Comment on attachment 347691 [details]
Patch

Attachment 347691 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8935679

New failing tests:
http/wpt/workers/name-property-enhanced.html
Comment 9 EWS Watchlist 2018-08-21 16:24:59 PDT 
Created attachment 347722 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 10 EWS Watchlist 2018-08-21 20:32:57 PDT 
Comment on attachment 347691 [details]
Patch

Attachment 347691 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8939324

New failing tests:
http/tests/security/canvas-remote-read-remote-video-redirect.html
Comment 11 EWS Watchlist 2018-08-21 20:33:08 PDT 
Created attachment 347759 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 12 Sihui Liu 2018-08-22 10:07:45 PDT 
Created attachment 347813 [details]
Patch
Comment 13 Sihui Liu 2018-08-22 13:05:25 PDT 
(In reply to Ryosuke Niwa from comment #7)
> Comment on attachment 347691 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=347691&action=review
> 
> > Source/WebKit/ChangeLog:7
> > +
> 
> Please explain why we want to do this in the change log.

Information added!
Comment 14 Geoffrey Garen 2018-08-22 15:50:50 PDT 
Comment on attachment 347813 [details]
Patch

r=me
Comment 15 WebKit Commit Bot 2018-08-22 22:53:04 PDT 
Comment on attachment 347813 [details]
Patch

Clearing flags on attachment: 347813

Committed r235216: <https://trac.webkit.org/changeset/235216>
Comment 16 WebKit Commit Bot 2018-08-22 22:53:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 17 Radar WebKit Bug Importer 2018-08-22 22:54:19 PDT 
<rdar://problem/43633183>
Comment 18 WebKit Commit Bot 2018-08-23 08:28:03 PDT 
Re-opened since this is blocked by bug 188887
Comment 19 Truitt Savell 2018-08-23 08:33:23 PDT 
This patch: https://trac.webkit.org/changeset/235216/webkit

Caused 50+ Layout Tests to Crash and 173 api Failures on Debug builds:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20%28Tests%29/builds/4593

Rollout out in: https://trac.webkit.org/changeset/235224/webkit
Comment 20 Sihui Liu 2018-08-23 11:45:21 PDT 
Created attachment 347942 [details]
Patch
Comment 21 Geoffrey Garen 2018-08-23 14:09:34 PDT 
Comment on attachment 347942 [details]
Patch

r=me
Comment 22 WebKit Commit Bot 2018-08-23 16:37:52 PDT 
Comment on attachment 347942 [details]
Patch

Clearing flags on attachment: 347942

Committed r235260: <https://trac.webkit.org/changeset/235260>
Comment 23 WebKit Commit Bot 2018-08-23 16:37:54 PDT 
All reviewed patches have been landed.  Closing bug.