Bug 188758 – WebKitTestRunner: Add watchOS entitlements

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

Testing WebKit on watchOS requires some specific entitlements.

[Jonathan Bedard]

Created attachment 347547 [details]
Patch

[Jonathan Bedard]

Talking with Tim Horton, while service workers are not supported on watchOS, in the event that they were supported in the future, someone would need to re-discover this entitlement, so I kept it.

[WebKit Commit Bot]

Comment on attachment 347547 [details]
Patch

Clearing flags on attachment: 347547

Committed r235099: <https://trac.webkit.org/changeset/235099>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43534326>

[Daniel Bates]

(In reply to Jonathan Bedard from comment #2)
> Talking with Tim Horton, while service workers are not supported on watchOS,
> in the event that they were supported in the future, someone would need to
> re-discover this entitlement, so I kept it.

We (the WebKit OpenSource Project and Apple) practice <https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it>: do not add functionality until deemed necessary. And this bug does just that. Adding "dead code" like what is being done in this patch hurts hackability and I suggest we revert <https://trac.webkit.org/changeset/235099>. The entitlement can be found by looking at <https://trac.webkit.org/browser/webkit/trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-iOS.entitlements?rev=228589> or grepping ChangeLogs and blaming code to find the code changes associated with the bug #182865 , which added the entitlement.

[Daniel Bates]

(In reply to Daniel Bates from comment #6)
> (In reply to Jonathan Bedard from comment #2)
> > Talking with Tim Horton, while service workers are not supported on watchOS,
> > in the event that they were supported in the future, someone would need to
> > re-discover this entitlement, so I kept it.
> 
> We (the WebKit OpenSource Project and Apple) practice
> <https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it>: do not add
> functionality until deemed necessary. And this bug does just that.

*And this bug does does the opposite: It adds functionality that is not necessary.

[Jonathan Bedard]

(In reply to Daniel Bates from comment #6)
> (In reply to Jonathan Bedard from comment #2)
> > Talking with Tim Horton, while service workers are not supported on watchOS,
> > in the event that they were supported in the future, someone would need to
> > re-discover this entitlement, so I kept it.
> 
> We (the WebKit OpenSource Project and Apple) practice
> <https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it>: do not add
> functionality until deemed necessary. And this bug does just that. Adding
> "dead code" like what is being done in this patch hurts hackability and I
> suggest we revert <https://trac.webkit.org/changeset/235099>. The
> entitlement can be found by looking at
> <https://trac.webkit.org/browser/webkit/trunk/Tools/WebKitTestRunner/
> Configurations/WebKitTestRunnerApp-iOS.entitlements?rev=228589> or grepping
> ChangeLogs and blaming code to find the code changes associated with the bug
> #182865 , which added the entitlement.

Do not revert <https://trac.webkit.org/changeset/235099>.

There are two entitlements in that change, one which is most certainly being used. If you would like to remove the Service Workers entitlement, then upload a patch to do so.