Bug 188751 - Update some libwebrtc third party libraries as per libwebrtc 984f1a80c0c
Summary: Update some libwebrtc third party libraries as per libwebrtc 984f1a80c0c
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-20 11:18 PDT by youenn fablet
Modified: 2018-08-21 14:05 PDT (History)
8 users (show)

See Also:


Attachments
Patch (6.70 MB, patch)
2018-08-20 12:58 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (6.69 MB, patch)
2018-08-20 14:27 PDT, youenn fablet
eric.carlson: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.88 MB, application/zip)
2018-08-20 23:32 PDT, EWS Watchlist
no flags Details
Patch for landing (6.67 MB, patch)
2018-08-21 10:38 PDT, youenn fablet
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-08-20 11:18:30 PDT
Update some libwebrtc third party libraries as per libwebrtc 984f1a80c0c
Comment 1 youenn fablet 2018-08-20 12:58:37 PDT
Created attachment 347534 [details]
Patch
Comment 2 youenn fablet 2018-08-20 14:27:47 PDT
Created attachment 347543 [details]
Patch
Comment 3 EWS Watchlist 2018-08-20 14:54:50 PDT
Attachment 347543 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/compare_msa.cc:25:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 12 in 496 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 EWS Watchlist 2018-08-20 23:32:44 PDT
Comment on attachment 347543 [details]
Patch

Attachment 347543 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8926593

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Comment 5 EWS Watchlist 2018-08-20 23:32:56 PDT
Created attachment 347615 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 Alejandro G. Castro 2018-08-21 05:10:11 PDT
That abseil-cpp library is a big part of the patch, why are we adding it and not compiling it?

Other than that LGTM r=me, I checked tests and did a small test with the Minibrowser and appr.tc. I can not flip the r? myself, probably the patch it is causing problems with the review form.
Comment 7 youenn fablet 2018-08-21 10:22:30 PDT
(In reply to Alejandro G. Castro from comment #6)
> That abseil-cpp library is a big part of the patch, why are we adding it and
> not compiling it?

It is only being used by the new libwebrtc which will be added in bug 188745.
bug 188745 will require updating libwebrtc CMake and probably compile abseil-cpp.

> Other than that LGTM r=me, I checked tests and did a small test with the
> Minibrowser and appr.tc. I can not flip the r? myself, probably the patch it
> is causing problems with the review form.
Comment 8 youenn fablet 2018-08-21 10:38:18 PDT
Created attachment 347658 [details]
Patch for landing
Comment 9 EWS Watchlist 2018-08-21 11:08:20 PDT
Attachment 347658 [details] did not pass style-queue:


ERROR: Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/compare_msa.cc:25:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
ERROR: Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 12 in 496 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 WebKit Commit Bot 2018-08-21 12:50:47 PDT
Comment on attachment 347658 [details]
Patch for landing

Rejecting attachment 347658 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 347658, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 5000 characters of output:
Source/third_party/libyuv/source/rotate_neon.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/rotate_neon64.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/rotate_win.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_any.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_common.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_gcc.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_msa.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_neon.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_neon64.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/row_win.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale_any.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale_argb.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale_common.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale_gcc.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale_msa.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale_neon.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale_neon64.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/scale_win.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/source/video_common.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/tools_libyuv/autoroller/roll_deps.py
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/tools_libyuv/get_landmines.py
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/basictypes_test.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/color_test.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/compare_test.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/convert_test.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/cpu_test.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/math_test.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/planar_test.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/scale_argb_test.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/scale_test.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/unit_test.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/unit_test.h
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/unit_test/video_common_test.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/util/Makefile
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/util/compare.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/util/cpuid.c
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/util/psnr.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/util/psnr.h
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/util/psnr_main.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/util/ssim.cc
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/util/ssim.h
	M	Source/ThirdParty/libwebrtc/Source/third_party/libyuv/util/yuvconvert.cc

ERROR from SVN:
A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output:

    The following files contain tab characters:

        trunk/Source/ThirdParty/libwebrtc/Source/third_party/abseil-cpp/absl/time/internal/cctz/src/tzfile.h

    Please use spaces instead to indent.
    If you must commit a file with tabs, use svn propset to set the "allow-tabs" property.
W: a43a8b3837038b16f0332f4d0ca10a2f526e14b6 and refs/remotes/origin/master differ, using rebase:
:040000 040000 338c60e38edd8e3edd055373c06a3c0d02b5ec5e 234160be1a72a1b8b741723df913bad3a0ed0353 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   93457d631ee..e2216bf95bc  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 235123 = 93457d631eeb1d3fa7e23f0f575fc68c15c23f62
r235124 = 8fdc4d5b33320002cfa1d2fe0a6778e28c28fc10
r235125 = d6b6a56a03f6826a6111abcd6ee7a45f8823eb36
r235126 = 4b29aca4598181ebc3e625d3da3e63fa4b6ad42c
r235127 = d11a94abf8b5ee896f835de90b0c39187a9e2e9c
r235128 = e2216bf95bcb609c1f8dfe941e76d8d8adf291d7
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/8933621
Comment 11 youenn fablet 2018-08-21 14:04:38 PDT
Committed r235135: <https://trac.webkit.org/changeset/235135>
Comment 12 Radar WebKit Bug Importer 2018-08-21 14:05:28 PDT
<rdar://problem/43576191>