RESOLVED FIXED 188739
Don't place "using namespace XXX;" in global space for unified source builds 
https://bugs.webkit.org/show_bug.cgi?id=188739
Summary Don't place "using namespace XXX;" in global space for unified source builds
Fujii Hironori
Reported 2018-08-19 22:41:30 PDT
Don't place "using namespace XXX;" in global space for unified source builds (In reply to Yusuke Suzuki from bug #188589 comment #25) > Maybe, I think we should remove `using namespace XXX` as much as possible > since we are now deploying unified builds. But I think this should be done > in a separate patch. (In reply to Darin Adler from bug #188589 comment #28) > Yes, I think we should move this over time. Unified builds makes it a risky > approach, and I think it’s always been risky from a "reduced clarity" point > of view.
Attachments
Patch (10.46 KB, patch)
2018-08-21 02:43 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (11.40 KB, patch)
2018-08-21 03:10 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (10.52 KB, patch)
2018-08-21 03:47 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-08-21 02:43:04 PDT
Created attachment 347624 [details] Patch
Fujii Hironori
Comment 2 2018-08-21 03:10:33 PDT
Created attachment 347625 [details] Patch
Fujii Hironori
Comment 3 2018-08-21 03:47:30 PDT
Created attachment 347626 [details] Patch
Yusuke Suzuki
Comment 4 2018-08-21 06:14:34 PDT
Comment on attachment 347626 [details] Patch Nice! r=me
Fujii Hironori
Comment 5 2018-08-21 06:26:59 PDT
Comment on attachment 347626 [details] Patch Thank you for the review!
WebKit Commit Bot
Comment 6 2018-08-21 06:55:20 PDT
Comment on attachment 347626 [details] Patch Clearing flags on attachment: 347626 Committed r235115: <https://trac.webkit.org/changeset/235115>
WebKit Commit Bot
Comment 7 2018-08-21 06:55:21 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-08-21 06:56:22 PDT
<rdar://problem/43559532>
Note You need to log in before you can comment on or make changes to this bug.