Bug 188735 - [Cocoa] Update uses of wrapper template functions in WebKit for clarity, simplicity, better ARC readiness
Summary: [Cocoa] Update uses of wrapper template functions in WebKit for clarity, simp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-19 16:31 PDT by Darin Adler
Modified: 2018-08-20 16:53 PDT (History)
4 users (show)

See Also:


Attachments
Patch (59.21 KB, patch)
2018-08-19 17:01 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (59.21 KB, patch)
2018-08-19 17:30 PDT, Darin Adler
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2018-08-19 16:31:59 PDT
[Cocoa] Update uses of wrapper template functions in WebKit for clarity, simplicity, better ARC readiness
Comment 1 Darin Adler 2018-08-19 17:01:09 PDT
Created attachment 347470 [details]
Patch
Comment 2 Darin Adler 2018-08-19 17:30:11 PDT
Created attachment 347473 [details]
Patch
Comment 3 mitz 2018-08-19 17:32:18 PDT
Comment on attachment 347473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347473&action=review

> Source/WebKit/ChangeLog:64
> +        (-[WKProcessPool _configuration]): Fixed a storage leak by removing leakRef,
> +        which was not balanaced. This is not a copy or create function, so it should not
> +        return an object that requires a release to balance it.

Yes! I noticed this bug a couple of weeks ago and hadn’t gotten around to writing it up.
Comment 4 Darin Adler 2018-08-19 17:53:39 PDT
Committed r235022: <https://trac.webkit.org/changeset/235022>
Comment 5 Radar WebKit Bug Importer 2018-08-20 16:53:03 PDT
<rdar://problem/43534485>