Bug 188703 – Start bringing up Unified Sources in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Start bringing up Unified Sources in WebKit2

[Tim Horton]

Created attachment 347375 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 347375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347375&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:1182
> +		2D11B9922126A286006F8878 /* UnifiedSource517.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEDD121269E4D00B9F73C /* UnifiedSource517.cpp */; };
> +		2D11B9932126A286006F8878 /* UnifiedSource518.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEC5D21269E4C00B9F73C /* UnifiedSource518.cpp */; };
> +		2D11B9942126A286006F8878 /* UnifiedSource519.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEC7D21269E4C00B9F73C /* UnifiedSource519.cpp */; };
> +		2D11B9952126A286006F8878 /* UnifiedSource520.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEC0621269E4B00B9F73C /* UnifiedSource520.cpp */; };
> +		2D11B9962126A286006F8878 /* UnifiedSource521.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEBE521269E4B00B9F73C /* UnifiedSource521.cpp */; };
> +		2D11B9972126A286006F8878 /* UnifiedSource522.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEC0C21269E4B00B9F73C /* UnifiedSource522.cpp */; };
> +		2D11B9982126A286006F8878 /* UnifiedSource523.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEC2E21269E4B00B9F73C /* UnifiedSource523.cpp */; };
> +		2D11B9992126A286006F8878 /* UnifiedSource524.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEC5C21269E4C00B9F73C /* UnifiedSource524.cpp */; };
> +		2D11B99A2126A286006F8878 /* UnifiedSource525.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEC7F21269E4C00B9F73C /* UnifiedSource525.cpp */; };
> +		2D11B99B2126A286006F8878 /* UnifiedSource526.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEC5721269E4B00B9F73C /* UnifiedSource526.cpp */; };
> +		2D11B99C2126A286006F8878 /* UnifiedSource527.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEC3021269E4B00B9F73C /* UnifiedSource527.cpp */; };
> +		2D11B99D2126A286006F8878 /* UnifiedSource528.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEDAD21269E4D00B9F73C /* UnifiedSource528.cpp */; };
> +		2D11B99E2126A286006F8878 /* UnifiedSource529.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEDCD21269E4D00B9F73C /* UnifiedSource529.cpp */; };
> +		2D11B99F2126A286006F8878 /* UnifiedSource530.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D7DEC5921269E4B00B9F73C /* UnifiedSource530.cpp */; };

Tooooo many. Please guesstimate.

[Tim Horton]

Created attachment 347377 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 347377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347377&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:11500
> +				2D11B7512126A282006F8878 /* UnifiedSource1-mm.mm in Sources */,

I wish these were called UnifiedSourceObjC-1.mm or something.

[Tim Horton]

Created attachment 347400 [details]
Patch

[Tim Horton]

Created attachment 347409 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 347409 [details]
Patch

Clearing flags on attachment: 347409

Committed r235006: <https://trac.webkit.org/changeset/235006>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43448839>

[Keith Miller]

Comment on attachment 347409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347409&action=review

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:-292
> -    FloatSize scaledSize = m_size;

When I ran into functions that heavily referenced types from JSC in WebCore I would just do:

using namespace JSC; 

on the first line of the function.