Bug 188690 - Modernize results.html
Summary: Modernize results.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-16 21:18 PDT by Simon Fraser (smfr)
Modified: 2018-08-24 12:56 PDT (History)
9 users (show)

See Also:


Attachments
Patch (98.47 KB, patch)
2018-08-16 21:20 PDT, Simon Fraser (smfr)
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-08-16 21:18:18 PDT
Modernize results.html
Comment 1 Simon Fraser (smfr) 2018-08-16 21:20:57 PDT
Created attachment 347348 [details]
Patch
Comment 2 Alexey Proskuryakov 2018-08-17 09:27:40 PDT
Comment on attachment 347348 [details]
Patch

r=me. Please confirm that the page still loads in other browsers - sometimes one's WebKit is so much under development that Safari won't launch to show the page :)
Comment 3 Simon Fraser (smfr) 2018-08-17 11:48:28 PDT
I tested current versions of Chrome and Firefox and both loaded the page fine.
Comment 4 Simon Fraser (smfr) 2018-08-17 11:57:10 PDT
https://trac.webkit.org/r234993
Comment 5 Radar WebKit Bug Importer 2018-08-17 11:58:16 PDT
<rdar://problem/43433940>
Comment 6 Ross Kirsling 2018-08-24 12:36:47 PDT
Ever since this patch, WinCairo layout tests which have a failing text diff and no -expected.png show up as "had no expected results (probably new)":

Before: https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Release%20(Tests)/r234991%20(1085)/results.html
After:  https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Release%20(Tests)/r234993%20(1086)/results.html

Now, this isn't a huge problem for us, as these test failures are all due to some bot image misconfiguration that we've yet to track down and not reproable locally, and presumably as soon as we fix the bot they'll all disappear anyway, but it is still weird that the dashboard now suggests a lack of expected results when you can clearly see otherwise.
Comment 7 Simon Fraser (smfr) 2018-08-24 12:49:49 PDT
Could you file a new bug for that? Thanks! I did fix some fallout recently.
Comment 8 Ross Kirsling 2018-08-24 12:56:30 PDT
(In reply to Simon Fraser (smfr) from comment #7)
> Could you file a new bug for that? Thanks! I did fix some fallout recently.

My pleasure! Submitted as bug 188927.