Bug 188690 – Modernize results.html

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Modernize results.html

[Simon Fraser (smfr)]

Created attachment 347348 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 347348 [details]
Patch

r=me. Please confirm that the page still loads in other browsers - sometimes one's WebKit is so much under development that Safari won't launch to show the page :)

[Simon Fraser (smfr)]

I tested current versions of Chrome and Firefox and both loaded the page fine.

[Simon Fraser (smfr)]

https://trac.webkit.org/r234993

[Radar WebKit Bug Importer]

<rdar://problem/43433940>

[Ross Kirsling]

Ever since this patch, WinCairo layout tests which have a failing text diff and no -expected.png show up as "had no expected results (probably new)":

Before: https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Release%20(Tests)/r234991%20(1085)/results.html
After:  https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Release%20(Tests)/r234993%20(1086)/results.html

Now, this isn't a huge problem for us, as these test failures are all due to some bot image misconfiguration that we've yet to track down and not reproable locally, and presumably as soon as we fix the bot they'll all disappear anyway, but it is still weird that the dashboard now suggests a lack of expected results when you can clearly see otherwise.

[Simon Fraser (smfr)]

Could you file a new bug for that? Thanks! I did fix some fallout recently.

[Ross Kirsling]

(In reply to Simon Fraser (smfr) from comment #7)
> Could you file a new bug for that? Thanks! I did fix some fallout recently.

My pleasure! Submitted as bug 188927.