Bug 188682 - Pass webPageID and webFrameID to NetworkLoad for speculative loads
Summary: Pass webPageID and webFrameID to NetworkLoad for speculative loads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-16 16:44 PDT by Alex Christensen
Modified: 2018-08-27 14:11 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.34 KB, patch)
2018-08-16 16:45 PDT, Alex Christensen 		youennf: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-16 16:44:02 PDT 
Pass webPageID and webFrameID to NetworkLoad for speculative loads
Comment 1 Alex Christensen 2018-08-16 16:45:26 PDT 
Created attachment 347322 [details]
Patch
Comment 2 Alex Christensen 2018-08-17 11:11:36 PDT 
http://trac.webkit.org/r234991
Comment 3 Radar WebKit Bug Importer 2018-08-17 11:13:26 PDT 
<rdar://problem/43431632>
Comment 4 Ryan Haddad 2018-08-17 17:11:54 PDT 
Reverted r234991 for reason:

Caused an assertion failure on the bots.

Committed r235001: <https://trac.webkit.org/changeset/235001>
Comment 5 Alex Christensen 2018-08-17 17:14:53 PDT 
imported/w3c/web-platform-tests/service-workers/service-worker/windowclient-navigate.https.html would sometimes fail the MESSAGE_CHECK(frame) in WebPageProxy::didReceiveAuthenticationChallengeProxy because sometimes the frame wouldn't exist in the UI process yet.  We really need to get rid of API::LoaderClient because we shouldn't even need the frame to exist.
Comment 6 Alex Christensen 2018-08-27 14:11:12 PDT 
r235398 removed that message check.  This is now valid.  Will reland.
Comment 7 Alex Christensen 2018-08-27 14:11:59 PDT 
http://trac.webkit.org/r235400