WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
188676
Add temporary SPI WKContextHandlesSafeBrowsing
https://bugs.webkit.org/show_bug.cgi?id=188676
Summary
Add temporary SPI WKContextHandlesSafeBrowsing
Alex Christensen
Reported
2018-08-16 13:36:23 PDT
Add temporary SPI WKContextHandlesSafeBrowsing
Attachments
Patch
(1.99 KB, patch)
2018-08-16 13:45 PDT
,
Alex Christensen
joepeck
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2018-08-16 13:45:01 PDT
Created
attachment 347299
[details]
Patch
Joseph Pecoraro
Comment 2
2018-08-16 15:07:47 PDT
Comment on
attachment 347299
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=347299&action=review
> Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.h:77 > +WK_EXPORT bool WKContextHandlesSafeBrowsing();
Shouldn't this have some WK_API_AVAILABLE(...) macro? I thought we were doing this for all our APIs and SPIs. I don't see it on any of our C APIs though =/
Alex Christensen
Comment 3
2018-08-16 15:08:26 PDT
We're only doing that for ObjC
Alex Christensen
Comment 4
2018-08-16 15:10:39 PDT
http://trac.webkit.org/r234960
Radar WebKit Bug Importer
Comment 5
2018-08-16 15:13:44 PDT
<
rdar://problem/43398475
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug