Bug 188676 - Add temporary SPI WKContextHandlesSafeBrowsing
Summary: Add temporary SPI WKContextHandlesSafeBrowsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-16 13:36 PDT by Alex Christensen
Modified: 2018-08-16 15:13 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2018-08-16 13:45 PDT, Alex Christensen 		joepeck: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-16 13:36:23 PDT 
Add temporary SPI WKContextHandlesSafeBrowsing
Comment 1 Alex Christensen 2018-08-16 13:45:01 PDT 
Created attachment 347299 [details]
Patch
Comment 2 Joseph Pecoraro 2018-08-16 15:07:47 PDT 
Comment on attachment 347299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347299&action=review

> Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.h:77
> +WK_EXPORT bool WKContextHandlesSafeBrowsing();

Shouldn't this have some WK_API_AVAILABLE(...) macro? I thought we were doing this for all our APIs and SPIs. I don't see it on any of our C APIs though =/
Comment 3 Alex Christensen 2018-08-16 15:08:26 PDT 
We're only doing that for ObjC
Comment 4 Alex Christensen 2018-08-16 15:10:39 PDT 
http://trac.webkit.org/r234960
Comment 5 Radar WebKit Bug Importer 2018-08-16 15:13:44 PDT 
<rdar://problem/43398475>