Bug 188666 - [ews-build] Add build steps ArchiveTestResults, UploadTestResults and ExtractTestResults
Summary: [ews-build] Add build steps ArchiveTestResults, UploadTestResults and Extract...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-16 11:43 PDT by Aakash Jain
Modified: 2018-08-16 13:42 PDT (History)
6 users (show)

See Also:


Attachments
Proposed patch (10.75 KB, patch)
2018-08-16 11:49 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-08-16 11:43:30 PDT
In Opensource EWS, after bots run layout-tests, they should upload the results to the server, so that people can click on a link and easily look at all the failures, crashes etc. For this we should add support for the corresponding build steps like ArchiveTestResults, UploadTestResults and ExtractTestResults.
Comment 1 Aakash Jain 2018-08-16 11:49:40 PDT
Created attachment 347280 [details]
Proposed patch

Tested in: http://ews-build.webkit-uat.org/#/builders/27/builds/23
Comment 2 EWS Watchlist 2018-08-16 11:53:13 PDT
Attachment 347280 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:33:  Module 'buildbot.process.properties' has no 'Interpolate' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:530:  [ExtractTestResults.__init__] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1145:  [TestArchiveTestResults.test_success] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1145:  [TestArchiveTestResults.test_success] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1160:  [TestArchiveTestResults.test_failure] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1160:  [TestArchiveTestResults.test_failure] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1191:  [TestUploadTestResults.test_success] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1191:  [TestUploadTestResults.test_success] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1217:  [TestExtractTestResults.test_success] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1217:  [TestExtractTestResults.test_success] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1235:  [TestExtractTestResults.test_failure] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:1235:  [TestExtractTestResults.test_failure] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
Total errors found: 12 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Aakash Jain 2018-08-16 12:23:03 PDT
Style checker warnings are false positive, mostly due to https://bugs.webkit.org/show_bug.cgi?id=188572
Comment 4 WebKit Commit Bot 2018-08-16 13:41:45 PDT
Comment on attachment 347280 [details]
Proposed patch

Clearing flags on attachment: 347280

Committed r234952: <https://trac.webkit.org/changeset/234952>
Comment 5 WebKit Commit Bot 2018-08-16 13:41:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-16 13:42:21 PDT
<rdar://problem/43394593>