Bug 188665 - Transition more WKWebViewConfiguration ivars to API::PageConfiguration values
Summary: Transition more WKWebViewConfiguration ivars to API::PageConfiguration values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-16 11:35 PDT by Alex Christensen
Modified: 2020-01-27 17:12 PST (History)
8 users (show)

See Also:

Attachments
Patch (7.24 KB, patch)
2018-08-16 11:36 PDT, Alex Christensen 		joepeck: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-16 11:35:44 PDT 
Transition more WKWebViewConfiguration ivars to API::PageConfiguration values
Comment 1 Alex Christensen 2018-08-16 11:36:56 PDT 
Created attachment 347279 [details]
Patch
Comment 2 Joseph Pecoraro 2018-08-16 11:49:09 PDT 
Comment on attachment 347279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347279&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:-376
> -    configuration->_cpuLimit = self->_cpuLimit;

These copies are removed since PageConfiguration::copy already handles it? Nice!
Comment 9 Alex Christensen 2020-01-27 17:11:38 PST 
This was committed long ago to http://trac.webkit.org/r234946
Comment 10 Radar WebKit Bug Importer 2020-01-27 17:12:20 PST 
<rdar://problem/58940859>