Bug 188664 - [watchOS] Upstream Proximity Networking (nee Wi-Fi Assertions)
Summary: [watchOS] Upstream Proximity Networking (nee Wi-Fi Assertions)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-16 11:29 PDT by Andy Estes
Modified: 2018-08-16 16:22 PDT (History)
12 users (show)

See Also:


Attachments
Patch (70.36 KB, patch)
2018-08-16 12:15 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (71.26 KB, patch)
2018-08-16 14:18 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (71.49 KB, patch)
2018-08-16 14:55 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-08-16 11:29:56 PDT
[watchOS] Upstream Proximity Networking (nee Wi-Fi Assertions)
Comment 1 Andy Estes 2018-08-16 12:15:23 PDT Comment hidden (obsolete)
Comment 2 EWS Watchlist 2018-08-16 12:17:20 PDT Comment hidden (obsolete)
Comment 3 Andy Estes 2018-08-16 14:18:31 PDT
Created attachment 347304 [details]
Patch
Comment 4 EWS Watchlist 2018-08-16 14:21:16 PDT
Attachment 347304 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityAssertion.mm:44:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.mm:80:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.mm:79:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.h:41:  WRM_iRATInterface is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 4 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Tim Horton 2018-08-16 14:28:45 PDT
Comment on attachment 347304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347304&action=review

> Source/WebKit/Configurations/WebKit.xcconfig:104
> +WK_PROXIMITY_NETWORKING_LDFLAGS = $(WK_PROXIMITY_NETWORKING_LDFLAGS_$(WK_PLATFORM_NAME));

Weird! This used to be about a framework, not a feature, but this is kind of nice too I guess.

It will only last until someone needs one of these things for something else, I guess.

> Source/WebKit/NetworkProcess/NetworkProcess.h:62
> +enum class WebsiteDataFetchOption;

I feel like this should sort between class and struct, but maybe not

> Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.h:82
> +    enum class State {

Give it a size?
Comment 6 Andy Estes 2018-08-16 14:55:24 PDT
Created attachment 347310 [details]
Patch
Comment 7 EWS Watchlist 2018-08-16 14:57:07 PDT Comment hidden (obsolete)
Comment 8 WebKit Commit Bot 2018-08-16 16:21:02 PDT
Comment on attachment 347310 [details]
Patch

Clearing flags on attachment: 347310

Committed r234968: <https://trac.webkit.org/changeset/234968>
Comment 9 WebKit Commit Bot 2018-08-16 16:21:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-08-16 16:22:17 PDT
<rdar://problem/43400980>