[watchOS] Upstream Proximity Networking (nee Wi-Fi Assertions)
Created attachment 347284 [details] Patch
Attachment 347284 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityAssertion.mm:44: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.mm:80: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.mm:79: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.h:41: WRM_iRATInterface is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 4 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 347304 [details] Patch
Attachment 347304 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityAssertion.mm:44: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.mm:80: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.mm:79: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.h:41: WRM_iRATInterface is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 4 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 347304 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347304&action=review > Source/WebKit/Configurations/WebKit.xcconfig:104 > +WK_PROXIMITY_NETWORKING_LDFLAGS = $(WK_PROXIMITY_NETWORKING_LDFLAGS_$(WK_PLATFORM_NAME)); Weird! This used to be about a framework, not a feature, but this is kind of nice too I guess. It will only last until someone needs one of these things for something else, I guess. > Source/WebKit/NetworkProcess/NetworkProcess.h:62 > +enum class WebsiteDataFetchOption; I feel like this should sort between class and struct, but maybe not > Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.h:82 > + enum class State { Give it a size?
Created attachment 347310 [details] Patch
Attachment 347310 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityAssertion.mm:44: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.mm:80: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.mm:79: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebKit/NetworkProcess/watchos/NetworkProximityManager.h:41: WRM_iRATInterface is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 4 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 347310 [details] Patch Clearing flags on attachment: 347310 Committed r234968: <https://trac.webkit.org/changeset/234968>
All reviewed patches have been landed. Closing bug.
<rdar://problem/43400980>