Bug 188634 - Custom element constructor doesn't use HTMLElement in new.target's realm
Summary: Custom element constructor doesn't use HTMLElement in new.target's realm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 154907
  Show dependency treegraph
 
Reported: 2018-08-15 21:18 PDT by Ryosuke Niwa
Modified: 2018-08-16 14:18 PDT (History)
8 users (show)

See Also:


Attachments
Fixes the bug (6.33 KB, patch)
2018-08-15 21:52 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Fixed the change log (6.34 KB, patch)
2018-08-15 21:59 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-08-15 21:18:57 PDT
When a custom element constructor invokes HTMLElement constructor of a different realm,
WebKit uses that realm's HTMLElement to construct the element instead of HTMLElement in new.target's realm.
Comment 1 Ryosuke Niwa 2018-08-15 21:52:51 PDT
Created attachment 347244 [details]
Fixes the bug
Comment 2 Radar WebKit Bug Importer 2018-08-15 21:53:52 PDT
<rdar://problem/43365966>
Comment 3 Build Bot 2018-08-15 21:56:11 PDT
Attachment 347244 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:14:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Ryosuke Niwa 2018-08-15 21:59:51 PDT
Created attachment 347245 [details]
Fixed the change log
Comment 5 Keith Miller 2018-08-16 12:58:07 PDT
Comment on attachment 347245 [details]
Fixed the change log

r=me.
Comment 6 Ryosuke Niwa 2018-08-16 13:50:59 PDT
Comment on attachment 347245 [details]
Fixed the change log

Thanks for the review!
Comment 7 WebKit Commit Bot 2018-08-16 14:18:09 PDT
Comment on attachment 347245 [details]
Fixed the change log

Clearing flags on attachment: 347245

Committed r234957: <https://trac.webkit.org/changeset/234957>
Comment 8 WebKit Commit Bot 2018-08-16 14:18:11 PDT
All reviewed patches have been landed.  Closing bug.