Bug 188630 - [LFC][BFC] Display::Box interface should reflect that padding is optional.
Summary: [LFC][BFC] Display::Box interface should reflect that padding is optional.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-15 21:11 PDT by zalan
Modified: 2018-08-16 12:44 PDT (History)
5 users (show)

See Also:


Attachments
Patch (14.03 KB, patch)
2018-08-15 21:38 PDT, zalan
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-08-15 21:11:18 PDT
ssia
Comment 1 zalan 2018-08-15 21:38:31 PDT
Created attachment 347241 [details]
Patch
Comment 2 zalan 2018-08-16 07:40:39 PDT
Committed r234925: <https://trac.webkit.org/changeset/234925>
Comment 3 Radar WebKit Bug Importer 2018-08-16 07:42:38 PDT
<rdar://problem/43380732>
Comment 4 Simon Fraser (smfr) 2018-08-16 12:40:07 PDT
Comment on attachment 347241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347241&action=review

> Source/WebCore/ChangeLog:8
> +        Certain type of boxes can't have paddings (see Layout::Box::isPaddingApplicable).

s/paddings/padding/

What's the utility of knowing that there is no padding vs. padding is zero? std::optional<> bloats class layout.
Comment 5 zalan 2018-08-16 12:44:29 PDT
(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 347241 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=347241&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Certain type of boxes can't have paddings (see Layout::Box::isPaddingApplicable).
> 
> s/paddings/padding/
> 
> What's the utility of knowing that there is no padding vs. padding is zero?
> std::optional<> bloats class layout.
From geometry point of view, there's no difference. This is about correctness. If we find std::optional excessive, it's fine to make it debug only and preserve the correctness part of it.