Bug 188628 - Update webkit-webgl-test-harness.js to provide more info on failing and partially passing tests
Summary: Update webkit-webgl-test-harness.js to provide more info on failing and parti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-15 20:50 PDT by Justin Fan
Modified: 2018-08-20 16:55 PDT (History)
4 users (show)

See Also:


Attachments
Patch (11.63 KB, patch)
2018-08-15 21:03 PDT, Justin Fan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2018-08-15 20:50:50 PDT
Update webkit-webgl-test-harness.js to provide more info on failing and partially passing tests
Comment 1 Justin Fan 2018-08-15 21:03:31 PDT
Created attachment 347239 [details]
Patch
Comment 2 EWS 2018-08-17 15:15:31 PDT
Comment on attachment 347239 [details]
Patch

Rejecting attachment 347239 [details] from commit-queue.

justin_fan@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 WebKit Commit Bot 2018-08-20 12:29:18 PDT
Comment on attachment 347239 [details]
Patch

Clearing flags on attachment: 347239

Committed r235090: <https://trac.webkit.org/changeset/235090>
Comment 4 WebKit Commit Bot 2018-08-20 12:29:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-08-20 16:55:14 PDT
<rdar://problem/43534557>