Bug 188621 - Can't share an app on AppStore to WeChat due to a release assert
Summary: Can't share an app on AppStore to WeChat due to a release assert
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-15 14:28 PDT by Ryosuke Niwa
Modified: 2018-08-15 16:37 PDT (History)
3 users (show)

See Also:

Attachments
Supresses the release assert (10.14 KB, patch)
2018-08-15 16:09 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixed GTK build (10.07 KB, patch)
2018-08-15 16:19 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-08-15 14:28:59 PDT 
The assertion we added in https://trac.webkit.org/r233808 is firing for WeChat’s share extension.

We need to add a linked-on-or-after check: ASSERT(RunLoop::isMain() || /* linked before iOS 12 */).

<rdar://problem/43343976>
Comment 1 Ryosuke Niwa 2018-08-15 16:09:55 PDT 
Created attachment 347219 [details]
Supresses the release assert
Comment 2 Ryosuke Niwa 2018-08-15 16:10:19 PDT 
Comment on attachment 347219 [details]
Supresses the release assert

The patch has already been reviewed by ggaren in person. Just waiting for EWS to land.
Comment 3 Ryosuke Niwa 2018-08-15 16:19:01 PDT 
Created attachment 347220 [details]
Fixed GTK build
Comment 4 Ryosuke Niwa 2018-08-15 16:37:33 PDT 
Comment on attachment 347220 [details]
Fixed GTK build

Clearing flags on attachment: 347220

Committed r234905: <https://trac.webkit.org/changeset/234905>
Comment 5 Ryosuke Niwa 2018-08-15 16:37:35 PDT 
All reviewed patches have been landed.  Closing bug.