Bug 188615 – Assert that calling CGSSetDenyWindowServerConnections(true) succeeds

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

If the call to CGSSetDenyWindowServerConnections(true) fails, it means there are open WindowServer connections at this point, and future WindowServer connections will not be denied. We should assert that this call succeeds.

[Per Arne Vollan]

Created attachment 347203 [details]
Patch

[Brent Fulgham]

Comment on attachment 347203 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347203&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:327
> +    ASSERT_UNUSED(retval, retval == kCGErrorSuccess);

Don't we want a RELEASE_ASSERT here? If this returns something besides kCGErrorSuccess, it means we still have an open CGSWindowServer connection, which we do not want!

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #2)
> Comment on attachment 347203 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=347203&action=review
> 
> > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:327
> > +    ASSERT_UNUSED(retval, retval == kCGErrorSuccess);
> 
> Don't we want a RELEASE_ASSERT here? If this returns something besides
> kCGErrorSuccess, it means we still have an open CGSWindowServer connection,
> which we do not want!

I will change it to RELEASE_ASSERT. Thanks for reviewing!

[Brent Fulgham]

Comment on attachment 347203 [details]
Patch

r=me if this is a RELEASE_ASSERT

[EWS Watchlist]

Comment on attachment 347203 [details]
Patch

Attachment 347203 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8872372

New failing tests:
css3/filters/backdrop/add-remove-add-backdrop-filter.html

[EWS Watchlist]

Created attachment 347215 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Per Arne Vollan]

Created attachment 347218 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 347218 [details]
Patch

Clearing flags on attachment: 347218

Committed r234929: <https://trac.webkit.org/changeset/234929>

[Radar WebKit Bug Importer]

<rdar://problem/43424172>