Bug 188605 - Remove unused CSSPrimitiveValue::createAllowingMarginQuirk
Summary: Remove unused CSSPrimitiveValue::createAllowingMarginQuirk
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-15 09:38 PDT by Alex Christensen
Modified: 2022-08-13 08:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.14 KB, patch)
2018-08-15 09:39 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (3.66 KB, patch)
2018-08-15 11:53 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.24 MB, application/zip)
2018-08-15 13:13 PDT, EWS Watchlist 		no flags Details
Patch (3.66 KB, patch)
2018-08-16 09:42 PDT, Alex Christensen 		joepeck: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-15 09:38:52 PDT 
Remove unused CSSPrimitiveValue::createAllowingMarginQuirk
Comment 1 Alex Christensen 2018-08-15 09:39:07 PDT 
Created attachment 347169 [details]
Patch
Comment 2 Alex Christensen 2018-08-15 11:53:25 PDT 
Created attachment 347186 [details]
Patch
Comment 3 EWS Watchlist 2018-08-15 13:13:36 PDT 
Comment on attachment 347186 [details]
Patch

Attachment 347186 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8870543

New failing tests:
css3/filters/backdrop/add-remove-add-backdrop-filter.html
Comment 4 EWS Watchlist 2018-08-15 13:13:38 PDT 
Created attachment 347199 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 Alex Christensen 2018-08-16 09:42:01 PDT 
Created attachment 347267 [details]
Patch
Comment 6 Joseph Pecoraro 2018-08-16 15:10:46 PDT 
Comment on attachment 347267 [details]
Patch

Nice! r=me
Comment 7 Ahmad Saleem 2022-08-13 08:00:44 PDT 
This commit:

https://github.com/WebKit/WebKit/commit/eb7fc1ad354884881ab821955893b756ff55f14

Addressed both concern, which this patch was trying to resolve:

* css/CSSPrimitiveValue.h: Remove unused createAllowingMarginQuirk function
and the FIXME-NEWPARSER that said we wouldn't need it any more and the
no-longer-needed isQuirkValue function.

* css/CSSValue.h: Remove m_isQuirkValue.

I am going to mark this as "RESOLVED CONFIGURATION CHANGED". Thanks!