Bug 188593 - Web Inspector: Table should not center rows when scrolling them into view
Summary: Web Inspector: Table should not center rows when scrolling them into view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-14 17:26 PDT by Matt Baker
Modified: 2018-08-14 23:10 PDT (History)
4 users (show)

See Also:

Attachments
[Video] Table scrolling - before (603.13 KB, video/mp4)
2018-08-14 17:33 PDT, Matt Baker 		no flags Details
[Video] Table scrolling - after (629.53 KB, video/mp4)
2018-08-14 17:33 PDT, Matt Baker 		no flags Details
Patch (1.55 KB, patch)
2018-08-14 17:36 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-08-14 17:26:22 PDT 
Using up/down arrow keys to scroll the table selection causes the row selection to jump around. Set opt_center false when calling Element.scrollIntoViewIfNeeded.
Comment 1 Radar WebKit Bug Importer 2018-08-14 17:32:14 PDT 
<rdar://problem/43311660>
Comment 2 Matt Baker 2018-08-14 17:33:11 PDT 
Created attachment 347136 [details]
[Video] Table scrolling - before
Comment 3 Matt Baker 2018-08-14 17:33:34 PDT 
Created attachment 347137 [details]
[Video] Table scrolling - after
Comment 4 Matt Baker 2018-08-14 17:36:08 PDT 
Created attachment 347139 [details]
Patch
Comment 5 Devin Rousso 2018-08-14 22:14:49 PDT 
Comment on attachment 347139 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347139&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Table.js:1176
> +            row.scrollIntoViewIfNeeded(false);

Looks like this might be dropped in favor of `Element.scrollIntoView()` at some point in the future.  We might have to change it then.
Comment 6 WebKit Commit Bot 2018-08-14 23:10:41 PDT 
Comment on attachment 347139 [details]
Patch

Clearing flags on attachment: 347139

Committed r234882: <https://trac.webkit.org/changeset/234882>
Comment 7 WebKit Commit Bot 2018-08-14 23:10:42 PDT 
All reviewed patches have been landed.  Closing bug.