Bug 188583 – [macOS] [WK2] Add infrastructure to test receiving file promises on drop

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Wenson Hsieh]

Add infrastructure to test receiving file promises on drop

[Wenson Hsieh]

Created attachment 347129 [details]
Patch

[EWS Watchlist]

Comment on attachment 347129 [details]
Patch

Attachment 347129 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8886279

New failing tests:
imported/blink/transitions/unprefixed-transform.html

[EWS Watchlist]

Created attachment 347328 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Andy Estes]

Comment on attachment 347129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347129&action=review

I'm not sure your unique filename finding logic in copyFile() is correct, but otherwise looks great! r=me

> Tools/TestWebKitAPI/mac/TestFilePromiseReceiver.mm:48
> +    _promisedTypeIdentifiers = adoptNS(promisedTypeIdentifiers.copy);

I don't think dot syntax makes sense for -copy. It's an operation, not a property.

> Tools/TestWebKitAPI/mac/TestFilePromiseReceiver.mm:101
> +        NSString *adjustedFileName = suffix ? fileNameWithNumericSuffix(fileName, suffix) : fileName;

Won't this try to copy to the same existing file path twice before appending a numeric suffix?

[Wenson Hsieh]

Comment on attachment 347129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347129&action=review

Thanks for the review!

>> Tools/TestWebKitAPI/mac/TestFilePromiseReceiver.mm:48
>> +    _promisedTypeIdentifiers = adoptNS(promisedTypeIdentifiers.copy);
> 
> I don't think dot syntax makes sense for -copy. It's an operation, not a property.

Sounds good — changed to [] notation.

>> Tools/TestWebKitAPI/mac/TestFilePromiseReceiver.mm:101
>> +        NSString *adjustedFileName = suffix ? fileNameWithNumericSuffix(fileName, suffix) : fileName;
> 
> Won't this try to copy to the same existing file path twice before appending a numeric suffix?

Ah, good catch! Fixed.

[Wenson Hsieh]

Created attachment 347347 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 347347 [details]
Patch for landing

Clearing flags on attachment: 347347

Committed r234976: <https://trac.webkit.org/changeset/234976>

[Radar WebKit Bug Importer]

<rdar://problem/43421379>