Bug 188580 - LayoutTest inspector/worker/debugger-pause.html sometimes times out
Summary: LayoutTest inspector/worker/debugger-pause.html sometimes times out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-14 14:30 PDT by Joseph Pecoraro
Modified: 2020-01-19 23:26 PST (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (4.41 KB, patch)
2018-08-14 15:10 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-08-14 14:30:00 PDT
LayoutTest inspector/worker/debugger-pause.html sometimes times out

See bug 164833.

> Test History:
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fworker%2Fdebugger-pause.html

I'll create an event for when the worker's main resource gets set.
Comment 1 Joseph Pecoraro 2018-08-14 15:10:45 PDT
Created attachment 347115 [details]
[PATCH] Proposed Fix
Comment 2 Matt Baker 2018-08-14 16:01:26 PDT
Comment on attachment 347115 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=347115&action=review

r=me

> Source/WebInspectorUI/UserInterface/Protocol/Target.js:79
> +        this.dispatchEventToListeners(WI.Target.Event.MainResourceAdded, {resource});

Nit: I wouldn't bother including data for the event. A listener can just query Target.mainResource if needed.
Comment 3 WebKit Commit Bot 2018-08-16 11:41:36 PDT
Comment on attachment 347115 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 347115

Committed r234945: <https://trac.webkit.org/changeset/234945>
Comment 4 WebKit Commit Bot 2018-08-16 11:41:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-08-16 11:42:21 PDT
<rdar://problem/43390767>