Bug 188579 - Remove api misuse check so that custom webcontent service identifier can be set at runtime
Summary: Remove api misuse check so that custom webcontent service identifier can be s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Richards
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-14 14:17 PDT by Ben Richards
Modified: 2018-08-14 19:33 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.62 KB, patch)
2018-08-14 14:18 PDT, Ben Richards 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Richards 2018-08-14 14:17:16 PDT 
Remove api misuse check so that custom webcontent service identifier can be set at runtime
Comment 1 Ben Richards 2018-08-14 14:18:31 PDT 
Created attachment 347109 [details]
Patch
Comment 2 WebKit Commit Bot 2018-08-14 16:22:15 PDT 
Comment on attachment 347109 [details]
Patch

Clearing flags on attachment: 347109

Committed r234865: <https://trac.webkit.org/changeset/234865>
Comment 3 WebKit Commit Bot 2018-08-14 16:22:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-08-14 16:24:30 PDT 
<rdar://problem/43308992>
Comment 5 Alexey Proskuryakov 2018-08-14 19:31:03 PDT 
This opens up possibilities for terrible misuse, what is the super important reason for this?
Comment 6 Ryosuke Niwa 2018-08-14 19:33:52 PDT 
(In reply to Alexey Proskuryakov from comment #5)
> This opens up possibilities for terrible misuse, what is the super important
> reason for this?

It's because we'd like to make this configurable at runtime. We would eventually bring back this API misuse check once we've solidified the feature.