188573 – Inline DataView accesses into DFG/FTL

RESOLVED FIXED 188573

Inline DataView accesses into DFG/FTL

https://bugs.webkit.org/show_bug.cgi?id=188573

Summary Inline DataView accesses into DFG/FTL

Saam Barati

Reported 2018-08-14 12:19:25 PDT

...

Attachments
WIP (21.50 KB, patch) 2018-08-14 23:57 PDT, Saam Barati	no flags	Details Formatted Diff Diff
WIP (29.47 KB, patch) 2018-08-16 11:35 PDT, Saam Barati	no flags	Details Formatted Diff Diff
WIP (29.66 KB, patch) 2018-08-16 12:40 PDT, Saam Barati	no flags	Details Formatted Diff Diff
WIP (31.82 KB, patch) 2018-08-16 14:43 PDT, Saam Barati	no flags	Details Formatted Diff Diff
WIP (38.13 KB, patch) 2018-08-16 19:10 PDT, Saam Barati	no flags	Details Formatted Diff Diff
WIP (42.59 KB, patch) 2018-08-16 20:00 PDT, Saam Barati	no flags	Details Formatted Diff Diff
WIP (54.62 KB, patch) 2018-08-17 01:19 PDT, Saam Barati	no flags	Details Formatted Diff Diff
WIP (57.04 KB, patch) 2018-08-17 16:53 PDT, Saam Barati	no flags	Details Formatted Diff Diff
WIP (72.44 KB, patch) 2018-08-19 14:03 PDT, Saam Barati	no flags	Details Formatted Diff Diff
WIP (81.12 KB, patch) 2018-08-19 18:32 PDT, Saam Barati	no flags	Details Formatted Diff Diff
WIP (84.33 KB, patch) 2018-08-20 00:41 PDT, Saam Barati	no flags	Details Formatted Diff Diff
patch (107.17 KB, patch) 2018-08-20 17:27 PDT, Saam Barati	no flags	Details Formatted Diff Diff
Show Obsolete (11) View All Add attachment proposed patch, testcase, etc.

Saam Barati

Comment 1 2018-08-14 12:19:50 PDT

<rdar://problem/43286746>

Saam Barati

Comment 2 2018-08-14 23:57:47 PDT

Created attachment 347152 [details] WIP it begins

Saam Barati

Comment 3 2018-08-16 11:35:03 PDT

Created attachment 347278 [details] WIP

Saam Barati

Comment 4 2018-08-16 12:40:05 PDT

Created attachment 347290 [details] WIP

Saam Barati

Comment 5 2018-08-16 14:43:57 PDT

Created attachment 347309 [details] WIP

Saam Barati

Comment 6 2018-08-16 19:10:28 PDT

Created attachment 347334 [details] WIP

Saam Barati

Comment 7 2018-08-16 20:00:18 PDT

Created attachment 347342 [details] WIP

Saam Barati

Comment 8 2018-08-17 01:19:13 PDT

Created attachment 347354 [details] WIP

Saam Barati

Comment 9 2018-08-17 16:53:20 PDT

Created attachment 347415 [details] WIP

Saam Barati

Comment 10 2018-08-19 14:03:23 PDT

Created attachment 347465 [details] WIP

Saam Barati

Comment 11 2018-08-19 18:32:42 PDT

Created attachment 347476 [details] WIP

EWS Watchlist

Comment 12 2018-08-19 20:36:58 PDT

Attachment 347476 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGNodeType.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Saam Barati

Comment 13 2018-08-20 00:41:37 PDT

Created attachment 347484 [details] WIP

Saam Barati

Comment 14 2018-08-20 17:27:34 PDT

Created attachment 347579 [details] patch

EWS Watchlist

Comment 15 2018-08-20 18:31:57 PDT

Attachment 347579 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGNodeType.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.

Michael Saboff

Comment 16 2018-08-20 18:37:36 PDT

Comment on attachment 347579 [details] patch r=me

Saam Barati

Comment 17 2018-08-20 22:37:40 PDT

Comment on attachment 347579 [details] patch Thanks for the review.

WebKit Commit Bot

Comment 18 2018-08-20 23:05:28 PDT

Comment on attachment 347579 [details] patch Clearing flags on attachment: 347579 Committed r235106: <https://trac.webkit.org/changeset/235106>

WebKit Commit Bot

Comment 19 2018-08-20 23:05:30 PDT

All reviewed patches have been landed. Closing bug.

Dawei Fenton (:realdawei)

Comment 20 2018-08-22 09:53:28 PDT

(In reply to WebKit Commit Bot from comment #18) > Comment on attachment 347579 [details] > patch > > Clearing flags on attachment: 347579 > > Committed r235106: <https://trac.webkit.org/changeset/235106> Looks like test "microbenchmarks/data-view-accesses.js" added in this revision has been failing on 32-bit JSC ever since it was added: https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/2469/steps/webkit-32bit-jsc-test/logs/stdio microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: Timed out after 339.000000 sec seconds! microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 1 0x2a94bb WTFCrash microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 2 0x4c08e startTimeoutThreadIfNeeded()::$_7::operator()() const microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 3 0x4bf6a WTF::Function<void ()>::CallableWrapper<startTimeoutThreadIfNeeded()::$_7>::call() microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 4 0x2d5649 WTF::Function<void ()>::operator()() const microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 5 0x3711f1 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 6 0x377c87 WTF::wtfThreadEntryPoint(void*) microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 7 0xa77044d5 _pthread_body microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 8 0xa770437a _pthread_body microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 9 0xa7703a56 thread_start microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: test_script_12852: line 2: 24446 Segmentation fault: 11 ( "$@" ../../.vm/JavaScriptCore.framework/Resources/jsc --useFTLJIT\=false --useFunctionDotArguments\=true --validateExceptionChecks\=true --useDollarVM\=true --maxPerThreadStackUsage\=1572864 --forceCodeBlockToJettisonDueToOldAge\=true --validateGraph\=true --useMaximalFlushInsertionPhase\=true --useConcurrentJIT\=false --thresholdForJITAfterWarmUp\=100 --scribbleFreeCells\=true data-view-accesses.js ) microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: ERROR: Unexpected exit code: 139

Saam Barati

Comment 21 2018-08-22 11:37:01 PDT

(In reply to David Fenton (:realdawei) from comment #20) > (In reply to WebKit Commit Bot from comment #18) > > Comment on attachment 347579 [details] > > patch > > > > Clearing flags on attachment: 347579 > > > > Committed r235106: <https://trac.webkit.org/changeset/235106> > > > Looks like test "microbenchmarks/data-view-accesses.js" added in this > revision has been failing on 32-bit JSC ever since it was added: > > https://build.webkit.org/builders/Apple%20High%20Sierra%2032- > bit%20JSC%20%28BuildAndTest%29/builds/2469/steps/webkit-32bit-jsc-test/logs/ > stdio > > microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: > Timed out after 339.000000 sec seconds! > microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 1 > 0x2a94bb WTFCrash > microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 2 > 0x4c08e startTimeoutThreadIfNeeded()::$_7::operator()() const > microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 3 > 0x4bf6a WTF::Function<void > ()>::CallableWrapper<startTimeoutThreadIfNeeded()::$_7>::call() > microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 4 > 0x2d5649 WTF::Function<void ()>::operator()() const > microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 5 > 0x3711f1 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) > microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 6 > 0x377c87 WTF::wtfThreadEntryPoint(void*) > microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 7 > 0xa77044d5 _pthread_body > microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 8 > 0xa770437a _pthread_body > microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: 9 > 0xa7703a56 thread_start > microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: > test_script_12852: line 2: 24446 Segmentation fault: 11 ( "$@" > ../../.vm/JavaScriptCore.framework/Resources/jsc --useFTLJIT\=false > --useFunctionDotArguments\=true --validateExceptionChecks\=true > --useDollarVM\=true --maxPerThreadStackUsage\=1572864 > --forceCodeBlockToJettisonDueToOldAge\=true --validateGraph\=true > --useMaximalFlushInsertionPhase\=true --useConcurrentJIT\=false > --thresholdForJITAfterWarmUp\=100 --scribbleFreeCells\=true > data-view-accesses.js ) > microbenchmarks/data-view-accesses.js.dfg-maximal-flush-validate-no-cjit: > ERROR: Unexpected exit code: 139 Ok we can make it run less.

Saam Barati

Comment 22 2018-08-22 11:54:03 PDT

Made the test run for less time in: https://trac.webkit.org/changeset/235189/webkit let me know if the issue still persists.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component JavaScriptCore

Assignee

Saam Barati

Reported

2018-08-14 12:19 PDT

Modified

2018-08-22 11:54 PDT History

CC List

19 users Show

URL

Keywords InRadar

Depends on

Blocks

188768

Dependencies

tree graph