Bug 188566 - Clean up CSSSelectorList after r234825
Summary: Clean up CSSSelectorList after r234825
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-14 11:17 PDT by Alex Christensen
Modified: 2018-08-17 17:22 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.63 KB, patch)
2018-08-14 11:20 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (5.58 KB, patch)
2018-08-15 11:56 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (12.88 MB, application/zip)
2018-08-16 03:10 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-14 11:17:14 PDT
Clean up CSSSelectorList after r234825
Comment 1 Alex Christensen 2018-08-14 11:20:50 PDT
Created attachment 347095 [details]
Patch
Comment 2 Alex Christensen 2018-08-15 11:56:16 PDT
Created attachment 347188 [details]
Patch
Comment 3 EWS Watchlist 2018-08-16 03:09:53 PDT
Comment on attachment 347188 [details]
Patch

Attachment 347188 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8878152

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Comment 4 EWS Watchlist 2018-08-16 03:10:05 PDT
Created attachment 347254 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Megan Gardner 2018-08-17 16:51:25 PDT
Comment on attachment 347188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347188&action=review

Assuming the win failure isn't an issue, and it's really fine to remove the deleteSelectors definition. r=me

> Source/WebCore/css/CSSSelectorList.h:-73
> -

It's not clear to me why this is being removed.

> Source/WebCore/css/StyleRule.cpp:222
>  }

Oh, these are being changed because they are now explicit?
Comment 6 Alex Christensen 2018-08-17 16:52:31 PDT
Comment on attachment 347188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347188&action=review

>> Source/WebCore/css/CSSSelectorList.h:-73
>> -
> 
> It's not clear to me why this is being removed.

It's an unused declaration.  There's no definition.
Comment 7 Megan Gardner 2018-08-17 16:56:19 PDT
Ah, I didn't realize this was deleted in the previous patch.
Comment 8 WebKit Commit Bot 2018-08-17 17:20:24 PDT
Comment on attachment 347188 [details]
Patch

Clearing flags on attachment: 347188

Committed r235002: <https://trac.webkit.org/changeset/235002>
Comment 9 WebKit Commit Bot 2018-08-17 17:20:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-08-17 17:22:09 PDT
<rdar://problem/43446397>