Bug 188565 – [Curl] Implement platform default timeout interval.

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Basuke Suzuki]

Curl port didn't implement platform default timeout interval. It treated zero value for timeout interval as no timeout.

Caught by this test:
 * http/tests/xmlhttprequest/on-network-timeout-error-during-preflight.html

[Basuke Suzuki]

Created attachment 347108 [details]
PATCH

[EWS Watchlist]

Attachment 347108 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Basuke Suzuki]

Created attachment 347111 [details]
PATCH

Fix ChangeLog style

[EWS Watchlist]

Attachment 347111 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Basuke Suzuki]

Created attachment 347112 [details]
PATCH

[Alex Christensen]

Comment on attachment 347112 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=347112&action=review

> Source/WebCore/platform/network/curl/CurlContext.cpp:610
> +    // CURLOPT_LOW_SPEED_LIMIT is used instead. It enables the spped watcher

speed

[Basuke Suzuki]

Created attachment 347117 [details]
PATCH

Alex, thanks for r+

[WebKit Commit Bot]

Comment on attachment 347117 [details]
PATCH

Clearing flags on attachment: 347117

Committed r234864: <https://trac.webkit.org/changeset/234864>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43308768>