Bug 188560 - [JSC] GetByIdStatus::m_wasSeenInJIT is touched in GetByIdStatus::slowVersion
Summary: [JSC] GetByIdStatus::m_wasSeenInJIT is touched in GetByIdStatus::slowVersion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-14 10:35 PDT by Yusuke Suzuki
Modified: 2018-08-14 10:47 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2018-08-14 10:37 PDT, Yusuke Suzuki 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-08-14 10:35:41 PDT 
[JSC] GetByIdStatus::m_wasSeenInJIT is touched in GetByIdStatus::slowVersion
Comment 1 Yusuke Suzuki 2018-08-14 10:37:07 PDT 
Created attachment 347089 [details]
Patch
Comment 2 Don Olmstead 2018-08-14 10:39:33 PDT 
Informal review r+. This was also detected with a UBSan run of ARES6.

This one looks like it might've been caught with clang's linter if we ran that as well.
Comment 3 Keith Miller 2018-08-14 10:43:14 PDT 
Comment on attachment 347089 [details]
Patch

Ugh, I wish there was a way we could get a compiler warning about members without default constructors not being initialized...
Comment 4 Yusuke Suzuki 2018-08-14 10:46:08 PDT 
(In reply to Keith Miller from comment #3)
> Comment on attachment 347089 [details]
> Patch
> 
> Ugh, I wish there was a way we could get a compiler warning about members
> without default constructors not being initialized...

Yeah, this case is a bit complicated. And it is awesome that UBSan catches this.

(In reply to Don Olmstead from comment #2)
> Informal review r+. This was also detected with a UBSan run of ARES6.
> 
> This one looks like it might've been caught with clang's linter if we ran
> that as well.

Nice!
Comment 5 Yusuke Suzuki 2018-08-14 10:46:41 PDT 
Committed r234855: <https://trac.webkit.org/changeset/234855>
Comment 6 Radar WebKit Bug Importer 2018-08-14 10:47:26 PDT 
<rdar://problem/43293111>