Bug 188557 - [DFG] DFGPredictionPropagation should set PrimaryPass when processing invariants
Summary: [DFG] DFGPredictionPropagation should set PrimaryPass when processing invariants
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-14 09:43 PDT by Yusuke Suzuki
Modified: 2018-08-14 10:24 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.65 KB, patch)
2018-08-14 09:45 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-08-14 09:43:58 PDT 
[DFG] DFGPredictionPropagation should set PrimaryPass when processing invariants
Comment 1 Yusuke Suzuki 2018-08-14 09:45:31 PDT 
Created attachment 347082 [details]
Patch
Comment 2 Mark Lam 2018-08-14 10:18:07 PDT 
Comment on attachment 347082 [details]
Patch

r=me.  Should we also specify an initializer for m_pass { PrimaryPass } (just to be pedantic)?
Comment 3 Yusuke Suzuki 2018-08-14 10:19:53 PDT 
(In reply to Mark Lam from comment #2)
> Comment on attachment 347082 [details]
> Patch
> 
> r=me.  Should we also specify an initializer for m_pass { PrimaryPass }
> (just to be pedantic)?

It sounds nice. I would like to keep both (initializer and `m_pass = PrimaryPass`). Since the latter offers good readability of PredictionPropagationPhase::run function.
Comment 4 Yusuke Suzuki 2018-08-14 10:23:57 PDT 
Committed r234853: <https://trac.webkit.org/changeset/234853>
Comment 5 Radar WebKit Bug Importer 2018-08-14 10:24:16 PDT 
<rdar://problem/43292220>