RESOLVED FIXED 188557
[DFG] DFGPredictionPropagation should set PrimaryPass when processing invariants 
https://bugs.webkit.org/show_bug.cgi?id=188557
Summary [DFG] DFGPredictionPropagation should set PrimaryPass when processing invariants
Yusuke Suzuki
Reported 2018-08-14 09:43:58 PDT
[DFG] DFGPredictionPropagation should set PrimaryPass when processing invariants
Attachments
Patch (1.65 KB, patch)
2018-08-14 09:45 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-08-14 09:45:31 PDT
Created attachment 347082 [details] Patch
Mark Lam
Comment 2 2018-08-14 10:18:07 PDT
Comment on attachment 347082 [details] Patch r=me. Should we also specify an initializer for m_pass { PrimaryPass } (just to be pedantic)?
Yusuke Suzuki
Comment 3 2018-08-14 10:19:53 PDT
(In reply to Mark Lam from comment #2) > Comment on attachment 347082 [details] > Patch > > r=me. Should we also specify an initializer for m_pass { PrimaryPass } > (just to be pedantic)? It sounds nice. I would like to keep both (initializer and `m_pass = PrimaryPass`). Since the latter offers good readability of PredictionPropagationPhase::run function.
Yusuke Suzuki
Comment 4 2018-08-14 10:23:57 PDT
Committed r234853: <https://trac.webkit.org/changeset/234853>
Radar WebKit Bug Importer
Comment 5 2018-08-14 10:24:16 PDT
<rdar://problem/43292220>
Note You need to log in before you can comment on or make changes to this bug.